if all values of quealy_subgroup are NA, everything will break

almartin82 / mapvizieR

visualizations and reports for the NWEA MAP assessment in R

Other

17 stars 6 forks source link

if all values of quealy_subgroup are NA, everything will break #315

Closed almartin82 closed 7 years ago

almartin82 commented 7 years ago

ie, if you tell it to group by studentgender and studentgender is NA, it will break.

almartin82 commented 7 years ago

might have something to do with roster_to_growth_df?

almartin82 commented 7 years ago

it has something to do with the new dplyr bindings / groupings not persisting.

almartin82 commented 7 years ago

@chrishaid did dplyr behavior change recently? this was a weird one. roster_to_growth_df was failing, but the root cause was that line 157/160 here wasn't taking - I had a simple data.frame, and calling dplyr::group_by didn't actually group the data.frame (meaning my disambiguation strategy failed).

The dplyr wrappers shouldn't have any impact here, because this is a data.frame internal to the function, not a mapvizieR_data object.

But, Occam's razor...

Thank god we have tests, I guess.