almartin82 / mapvizieR

visualizations and reports for the NWEA MAP assessment in R
Other
17 stars 6 forks source link

mapvizieR function is broken #320

Closed chrishaid closed 7 years ago

chrishaid commented 7 years ago

This callL

map_mv_15 <-
    mapvizieR(
        cdf = map_sep$cdf,
        roster = map_sep$roster
    )

fails with this error:

Error in UseMethod("left_join") : 
  no applicable method for 'left_join' applied to an object of class "c('matrix', 'list')"
In addition: Warning messages:
1: In left_join_impl(x, y, by$x, by$y, suffix$x, suffix$y) :
  joining character vector and factor, coercing into character vector
2: In left_join_impl(x, y, by$x, by$y, suffix$x, suffix$y) :
  joining character vector and factor, coercing into character vector
3: In cbind(scaffold, start_data, end_data) :
  number of rows of result is not a multiple of vector length (arg 2)

I have no idea what is going on but, I've got production code failing left and right after an updating the package in the last 24 hours.

Can we freeze development on the mapvizieR object and methods that create it for the time being.

chrishaid commented 7 years ago

Issue was caused by using the current development version of dplyr.

moving back to this commit hadley/dplyr@63d4a9f5 solved the problem locally.

I imagine current changes in the development dplyr that brok mapvizieR might break it when Hadley and team release the next version of dplyr.