almartin82 / njschooldata

a simple, consistent interface for accessing NJ DOE school data in R
Other
11 stars 4 forks source link

Extract postsecondary matriculation counts #143

Closed chiouey closed 4 years ago

chiouey commented 4 years ago

proposed changes

test

testthat::test_file("tests/testthat/test_report_card.R")

chiouey commented 4 years ago

I think this is all but there! I see two ground truth tests that were failing for me -

test_report_card.R:130: failure: extract_rc_college_matric ground truth values
`%>%`(...) not equal to 85.3.
1/1 mismatches
[1] 67.2 - 85.3 == -18.1

test_report_card.R:137: failure: extract_rc_college_matric ground truth values
`%>%`(...) not equal to 93.6.
1/1 mismatches
[1] 87.4 - 93.6 == -6.2

Might be a 12 month vs 16 month thing? Can we check these before merging?

fixed! i must have been looking at the wrong flat file while writing the test and then didn't bother checking it 😴

almartin82 commented 4 years ago

Looks good!

There was a merge conflict on geo.R - I took a look at both files and resolved in 3179c34 - @chiouey can you take a look at that and confirm? ward_gcount_aggs goes away and we keep ward_matric_aggs from postsec?

master vs postsec were the two branches

chiouey commented 4 years ago

Looks good!

There was a merge conflict on geo.R - I took a look at both files and resolved in 3179c34 - @chiouey can you take a look at that and confirm? ward_gcount_aggs goes away and we keep ward_matric_aggs from postsec?

master vs postsec were the two branches

Huh -- not totally sure what happened there. ward_gcount_aggs and ward_grate_aggs definitely should still be around. Maybe I didn't use the right branch as base? How can I fix?

@almartin82

almartin82 commented 4 years ago

ok! I will find those functions and restore

almartin82 commented 4 years ago

@chiouey restored those