almartin82 / njschooldata

a simple, consistent interface for accessing NJ DOE school data in R
Other
11 stars 4 forks source link

refactor enr pulls to work with 2021 data #164

Closed almartin82 closed 2 years ago

almartin82 commented 2 years ago

description of the change

changes made in 2020 look to be permanent, so did some refactoring to separate general '2020-onward' stuff from 'weird 2020 mistakes'

how to test

test_file('tests/testthat/test_enr.R') should return zero failures [ FAIL 0 | WARN 6 | SKIP 0 | PASS 97 ] locally

(warnings appear to mostly be badly formatted 1999 csv files)

almartin82 commented 2 years ago

@chrishaid review this PR first (merges into enr_refactor