Open ova2 opened 9 years ago
Hm passing start and end via .draw is being deprecated (you should see a deprecation warning in your console). See commit https://github.com/almende/chap-links-library/commit/15fcd8347786e687116b44544f464b69f7c6dbc5). I didn't realize this would be a breaking change, should have been published as a breaking release.
Yes, I know this deprecation warning and I know your commit. We don't pass options via .draw due to this warning. But now, we have a problem because start and end dates are not considered. I think this is easy to fix. Thanks in advance.
I don't expect to have time to fix this very soon, but if you could put together a PR would be great.
Sure, I can put PR, but a little bit later (the same - no time to fix this very soon).
Done. The pull request is here https://github.com/almende/chap-links-library/pull/351/files Thanks.
The docu says:
start
: "The initial start date for the axis of the timeline. If not provided, the earliest date present in the events is taken as start date."end
: "The initial end date for the axis of the timeline. If not provided, the latest date present in the events is taken as end date."But you have removed in the last version the logic for
this.options.start
andthis.options.end
from thefunction links.Timeline.prototype.draw
. We hadbut now we have
The problem is that
this.setVisibleChartRangeAuto()
doesn't takestart
andend
options into account. They are simple ignored.