search

almende / vis

⚠️ This project is not maintained anymore! Please go to https://github.com/visjs
7.84k stars 1.48k forks source link

[Graph2d] line chart go behind of bar chart #1385

Closed amrocs closed 9 years ago

amrocs commented 9 years ago

I am using Graph2d, and I want to overlay line chart on bar chart. But vis.js looks like ignoring group order, and line char always go behind of bar chart. Is there a way to take line chart to front ? I want "order" option like z-index.

amrocs commented 9 years ago

I found drawing order codes in vis.js (line 24463 to 24470). In there, drawing order is fixed with comment "bar needs to be drawn enmasse".

I cut BarFunctions.draw and paste before group.draw, line chart moved to front.

Usually, draw area of bar chart is larger than line chart (line chart is only svg thin path and some small circles), so I think bar chart should drawn before drawing line chart. And in future, best way is groups have drawing order.

josdejong commented 9 years ago

Thanks, I changed the drawing order following your suggestion such that lines are drawn on top of bars.