search

almende / vis

⚠️ This project is not maintained anymore! Please go to https://github.com/visjs
7.85k stars 1.48k forks source link

Allow setting title of customtime in constructor #4117

Open kbasten opened 6 years ago

kbasten commented 6 years ago

This allows setting of custom time bar title in the constructor, allowing calls like the following to correctly display the title.

graph.addCustomTime(new Date(1531135747 * 1000), 'custom_id', { title: 'custom title' });

yotamberk commented 6 years ago

I've now branched out to a new fork of my own including only Timeline. I've applied your change here: https://github.com/yotamberk/timeline-plus and can be used via npm here: https://www.npmjs.com/package/timeline-plus Awesome fix! Thanks for your contribution! Future PRs will be reviewed and added in the new fork