[Timeline] Addittional fix for page scrolling over timeline

almende / vis

⚠️ This project is not maintained anymore! Please go to https://github.com/visjs

7.85k stars 1.48k forks source link

[Timeline] Addittional fix for page scrolling over timeline #4143

Open kozel-sd opened 6 years ago

kozel-sd commented 6 years ago

One more improvement (I hope so) for #3734. After this fix, Timeline only does preventDefault on a vertical scroll event if the timeline has actually been scrolled. AFAIK this behaviour would be consistent with what all popular GUI systems do.

yotamberk commented 6 years ago

Can you please submit this change to https://github.com/yotamberk/timeline ? I am only maintaining timeline changes there.

kozel-sd commented 6 years ago

OK, I'll do it a bit later

hypery2k commented 5 years ago

if anyone just needs this scroll bugfix, i published a fork on npm: https://github.com/holisticon/vis