search

almende / vis

⚠️ This project is not maintained anymore! Please go to https://github.com/visjs
7.85k stars 1.48k forks source link

dataManipulation toolbar buttons not touchable #653

Closed mattsouth closed 9 years ago

mattsouth commented 9 years ago

The buttons on the manipulation toolbar do not respond to touch events, see http://visjs.org/examples/network/21_data_manipulation.html for demo (on ipad and android). I can see onclick events bound to the buttons (e.g. lib/network/mixins/ManipulationMixin.js line 197) but no explicit touch handling.

AlexDM0 commented 9 years ago

Hi Matt,

I've pushed a fix for this to the develop branch. Thanks for letting us know.

Regards,

Alex

mattsouth commented 9 years ago

Looks good to me, the buttons now work on touch screens. I notice though, that the develop branch seems to have lost two useful behaviours on adding an edge:

  1. visible "partial edge" as you connect two nodes,
  2. unfreeze after edge is connected. Perhaps these are side effects of another fix on this branch?
AlexDM0 commented 9 years ago

Hi Matt,

Yes, these have been fixed. I'll push them to develop.

Cheers

AlexDM0 commented 9 years ago

It's on develop now.

Cheers

mattsouth commented 9 years ago

Yep that's done it.

thanks Alex

mattsouth commented 9 years ago

Hi Alex, I noticed something else with the touch interface now, not sure if it needs a new issue or not. It now takes two touches to place a node or an edge. The first touch does nothing and the second places the node or starts the edge.

AlexDM0 commented 9 years ago

Hi Matt,

I'll look into it. Is this only on touch devices or also on pc?

Regards,

Alex

mattsouth commented 9 years ago

Only on touch devices. I've seen this on an ipad (safari) and a windows tablet (chrome).

AlexDM0 commented 9 years ago

Hi Matt,

I'll see what we can do. We're doing a full rewrite of the network with Hammer 2.0 and rechecking all the behaviour. I'm not sure if this will make it in the 3.x versioning but we'll see what we can do.

Regards,

Alex

AlexDM0 commented 9 years ago

Hi Matt,

This has been fixed in v4 which we just released today!

Regards,

Alex

mattsouth commented 9 years ago

Hey thanks for the heads up Alex. Excellent news. I only just checkd github earlier this week to see how you were getting on. I'll check it out.

Matt

From: "Alex" notifications@github.com Sent: 22 May 2015 14:47 To: "almende/vis" vis@noreply.github.com Cc: "Matt South" matt@mattsouth.net Subject: Re: [vis] dataManipulation toolbar buttons not touchable (#653)

Hi Matt,

This has been fixed in v4 which we just released today!

Regards,

Alex

Reply to this email directly or view it on GitHub.