search

almenscorner / IntuneCD

Tool to backup, update and document configurations in Intune
MIT License
277 stars 35 forks source link

[BUG] Backup of ESP profiles fails if a mandatory app no longer exists #162

Closed fmdkrenepedersen closed 7 months ago

fmdkrenepedersen commented 7 months ago

Describe the bug Backup fails if a mandatory app no longer exists, during backup of ESP profiles.

To Reproduce Steps to reproduce the behavior:

Delete an app that is selected as mandatory within a ESP profile.

Expected behavior Continue backup even though a mandatory app is deleted.

Screenshots image

image

Run type (please complete the following information):

almenscorner commented 7 months ago

This is your queue to clean it up ;)

Jokes aside, I will include an extra check for empty app responses while backing up and skipping if the response is None so it will continue. I'll add that in an upcoming version.

fmdkrenepedersen commented 7 months ago

Haha, point taken.

Thanks. Keep up the amazing work! Much appreciated :-)

almenscorner commented 7 months ago

This fix is now included in the latest beta, please do a test run and verify that the backup completes even if the app is removed.

To test, install the latest beta: pip3 install IntuneCD==2.0.9b1

fmdkrenepedersen commented 7 months ago

Confirmed working with 2.0.9b1.

THANKS!

almenscorner commented 7 months ago

Fantastic :) I will close this issue once 2.0.9 is released!