almindor / etherwall

Ethereum QT5 Wallet
GNU General Public License v3.0
142 stars 59 forks source link

Invalid contract name #112

Open hallwaymonitor opened 5 years ago

hallwaymonitor commented 5 years ago

When I try to "Add Existing Contract" in Etherwall for ERC-20 stablecoins such as USDC, TUSD or PAX then after adding the contract address I will get "invalid contract name" status and the "Name" field is empty. The "Interface" field gets automatically populated. If I type the "Name" then I'm able to save but I will not get the Token symbol and hence I cannot send any stablecoins from my wallet. I even tried to add manually the Contract ABI from etherscan but still get "invalid contract name" status. I have successfully managed to add other ERC-20 tokens by simply adding the contract address. Can you please help how can I add my stablecoins in Etherwall?

https://etherscan.io/address/0xa0b86991c6218b36c1d19d4a2e9eb0ce3606eb48#code https://etherscan.io/address/0x0000000000085d4780B73119b644AE5ecd22b376 https://etherscan.io/address/0x8e870d67f660d95d5be530380d0ec0bd388289e1

almindor commented 5 years ago

I can confirm getting empty (thus invalid) name for the address. I'll have to investigate the details tomorrow.

If you're in a hurry you can always export the given address you need to get these out from and use an alternative wallet.

almindor commented 5 years ago

Sorry, I didn't get to this today. I've had a crazy day and didn't have the time to check it out. On first glance tho it seems like those contracts aren't ERC20 compatible (e.g. missing things like name call).

I'll try and get this done tomorrow.

almindor commented 5 years ago

I went through all three addresses on etherscan and it seems neither of them are an ERC20 compatible contract. See here for the definition.

The main things an ERC20 contract needs are functions balanceOf, transfer and preferably also constants name, symbol and decimals (name is btw. why this error shows as EW tries to get it from that constant but it doesn't exist).

As far as I can say these are some sort of Proxy contracts. Are you sure the actual addresses for these tokens aren't something different?

hallwaymonitor commented 5 years ago

Hi.

I'm not sure the actual addresses for these tokens aren't something different. I just took them from etherscan. This topic is too technical for me to be honest. However, I tested that I can use my MetaMask wallet as a workaround when I imported the JSON file there that I exported from Etherwall previously. Somehow MetaMask immediately recognized my USD Coins and I did not even have to add the contract there manually.

Anyways, thanks for the support. I can use MetaMask whenever I want to send these stablecoins out of my Etherwall wallet.