search

almindor / etherwall

Ethereum QT5 Wallet
GNU General Public License v3.0
142 stars 59 forks source link

Hardware wallet support #4

Closed ulrichard closed 7 years ago

ulrichard commented 8 years ago

It would be great if hardware wallets such as trezor or keepkey were supported.

almindor commented 8 years ago

I agree. However until someone creates a hw solution compatible with ethereum I can't do much about it.

Etherwall is a thin GUI client on top of Geth/Eth itself. It doesn't handle account creation etc. I do want to add account export/import functionality tho, so you can at least put your private keys somewhere else easily without the need to know where Geth stores them on each platform.

ulrichard commented 8 years ago

Somebody told me that ethereum uses the same signature algorithm as bitcoin. Ether is already registered with BIP044 at index 60 : https://github.com/satoshilabs/slips/blob/master/slip-0044.md Thus it should be possible to use existing hw solutions such as trezor.

almindor commented 8 years ago

I've asked Trezor but got no answer. I guess they don't talk to us little guys (funny coz I'm Slovak and can speak Czech).

The plan is to add QR export for your encrypted account (so even if someone steals the QR/paper, it's still PW protected). I should have this by v1.1.0. Version 1.0.0 is just around the corner with a lot of new features and integrated Geth support.

ulrichard commented 8 years ago

looks like it's not as straightforward as I thought, but can be done as demonstrated by https://github.com/quorumwallet

evieira55 commented 8 years ago

they have. its called ledger nano s here is the link https://www.ledgerwallet.com/products/12-ledger-nano-s

ulrichard commented 8 years ago

Does the ethereum support of the ledger nano s run anywhere other than their chrome plugin? I ask, because their BitCoin electrum integration is lagging since they have this chrome app.

almindor commented 8 years ago

This is a bit too much work for me at this point. If anyone is willing to tackle this I'll provide full support as much I can.

almindor commented 7 years ago

The new geth is now adding HD support where it should be, so I might add support to this when they finalize their designs.

almindor commented 7 years ago

Also of note: https://doc.satoshilabs.com/trezor-tech/api-protobuf.html

Sadly there's no higher level C/C++ implementation only python and java so I'd have to implement all the way down to the USB HID.

The other alternative is to run an instance of https://github.com/trezor/trezord and use it's HTTP protocol which is a bit easier and has the advantage of not needing upkeep in code (e.g. if they add additional features I just need to add the GET/POST calls). Might seem less secure but they're using USB HID which is fully hijackable anyhow.

almindor commented 7 years ago

TREZOR is now supported