search

almindor / etherwall

Ethereum QT5 Wallet
GNU General Public License v3.0
143 stars 59 forks source link

Password change for Wallet #43

Open UGatgithub opened 7 years ago

UGatgithub commented 7 years ago

Another improvement proposal. According to https://github.com/ethereum/go-ethereum/wiki/Managing-your-accounts it seems to be possible to change a wallet password using geth but that's not very user friendly and so far I found no implementation of this feature in an official wallet (mist or ethereum wallet). Would be good if Etherwall could offer this functionality! —— Account update

$ geth account update a94f5374fce5edbc8e2a8697c15331677e6ebf0b Unlocking account a94f5374fce5edbc8e2a8697c15331677e6ebf0b | Attempt 1/3 Passphrase: 0xa94f5374fce5edbc8e2a8697c15331677e6ebf0b Account 'a94f5374fce5edbc8e2a8697c15331677e6ebf0b' unlocked. Please give a new password. Do not forget this password. Passphrase: Repeat Passphrase: 0xa94f5374fce5edbc8e2a8697c15331677e6ebf0b

almindor commented 7 years ago

Good idea, will look into it.

almindor commented 7 years ago

So this is actually hard to do due to how geth implements it.

They didn't provide any IPC way of doing a password change and the cmdline way only works if geth is not running. I'll have to postpone this until they either add the IPC support, or Etherwall moves off (local) geth completely.

UGatgithub commented 7 years ago

OK, I understand. Just a thought: Wouldn't it be possible to stop Geth (informing the user with a related Do you want to proceed Yes/No dialog), changing the PW if Yes and then re-starting Geth?

almindor commented 7 years ago

That's just too insecure. I want to decouple Etherwall from geth in the future, thin client was the 1st step. NExt one is account management directly via etherwall (geth compatible of course)

UGatgithub commented 7 years ago

Understood, so no local geth with the complete blockchain downloaded in future meaning more centralization of the blockchain ...

almindor commented 7 years ago

I think I'll leave the option of using local geth for full node but it will become somewhat unrealistic for normal people to run a full node soon unless they can aggressively prune the DB.

almindor commented 7 years ago

I'm also considering a smart-contract based "run a node for etherwall" solution.