search

almindor / etherwall

Ethereum QT5 Wallet
GNU General Public License v3.0
142 stars 59 forks source link

ERC20 support #56

Closed almindor closed 6 years ago

almindor commented 7 years ago

Add support for balances and sending of ERC20 tokens

almindor commented 6 years ago

Made a new pre-release for v2.0.7

If you can please re-test with all the contracts again by removing and re-adding them. Every contract should now be detected with the proper symbol. The main issues here was deviation from ERC20 standard by the contract creators, but they're mostly minor. One bug on etherwall's side was handling of bytes type UTF-8/String detection.

UGatgithub commented 6 years ago

Takes quite some time at startup while Processing eth_getLogs. Yes now the OMG symbol also gets loaded, regarding balanceOf I waited until sync was completed and I do get Results for REP, GNT and OMG now. :-)

Can you define the function balanceOf as default selection? Would also be good if the _owner address could be selected from defined accounts.

Rob-2017 commented 6 years ago

@Rob-2017 So you named your watch with the address? That's what it seems.

yes... :) i was a bit confused because of that geth issue. very strange something prevent 1.7.0 to connect but not 1.6.7. that geth error Fatal:Error starting protocol stack: Access is denied shall appear if another geth instance is running already and block the ports. but that happens even if i start geth from console right after os boot. nothing else is running and no geth in taskmanager. its no win7 issue because it works on another win7 comp. i will try to remove all files wich are related to geth and etherwallet in appdata to get a cleaner reinstall. the wallet.dat is exported and save. on the working comp i tried many token with new pre2.0.7 all where shown correct with symbol just DGD - Digix Global 0xE0B7927c4aF23765Cb51314A0E0521A9645F0E2A had no symbol. now i will see if i can manage to get the correct ballance for the different accounts with the future releases but first try to fix that geth prob. rgds

almindor commented 6 years ago

@UGatgithub this is just the skeleton, full ERC20 support will make it click-easy to check your balances and send tokens.

@Rob-2017 I noticed one thing. If you don't delete the other non-keystore folders from the main ethereum data folder and resync things go strange. Maybe try doing that, but make 100% sure all your accounts are safe!

almindor commented 6 years ago

When it comes to "digix global" 0xE0B7927c4aF23765Cb51314A0E0521A9645F0E2A they don't implement "symbol" function. I plan to support those tokens too but I need to add a UI element for them where you'd have to type in the symbol name yourself if it's detected as missing. Same for missing the decimals indicator.

almindor commented 6 years ago

First alpha release of fully erc20 compatible version is here: https://github.com/almindor/etherwall/releases/tag/v2.1.0-alpha1

I'd appreciate if you guys could test this out as much as possible. Feel free to switch to testnet (needs to be full client for that)

I'll push binaries as soon as I can find the time to build them (day or two).

almindor commented 6 years ago

Fixed via 2.1.0 release