search

almindor / harbour-jTox

Sailfish OS native tox implementation for Jolla
GNU General Public License v3.0
12 stars 4 forks source link

Double tapping enter crashes jTox. #51

Closed patrickrifici closed 6 years ago

patrickrifici commented 6 years ago

In the current release of jTox (v1.3.0) with toxcore v0.2.2, double tapping the enter key while in a chat window will cause jTox to crash. Attempting to open jTox afterwards will result in normal function until the contact which was open during the crash comes online, at which point jTox will crash again. The only way to rectify the issue is to delete any jTox data found in .config and .local and then either create a new Tox ID or import a backup.

almindor commented 6 years ago

Thanks this was a big oversight on my end.

Toxcore does not allow empty message sends. QML keyboard sends me a message with just \n which I trim away and it causes empty message to be forwarded. Same for pending.

I'm about to release 1.3.1 with a fix for this as well as any remaining invalid pending messages. You can also currently work-around the always-crash on pending send by long-pressing the pending message and deleting it. But you need to do this before your friend is registered as being online.

almindor commented 6 years ago

Fixed in latest master, will release 1.3.1 shortly

ghost commented 6 years ago

Still crashing on accepting transfer in -v 1.3.1 : (

almindor commented 6 years ago

@Caballlero accepting transfer? I think that's a separate issue, this was about sending messages by pressing enter twice. Can you open an issue with details about your crash please?

ghost commented 6 years ago

ok