search

almindor / lighthouse

SailfishOS (Jolla) System Monitor App
GNU General Public License v3.0
21 stars 9 forks source link

fix cpu view for portrait/landscape mode #24

Closed antis81 closed 5 years ago

antis81 commented 5 years ago

The poor man's fix to anchored items. Better use a "Grid" positioner. However as long as no more than two items are visible on screen it goes fine with setting the anchors.

Also fixes scrolling of the cores list (it is visible in landscape screenshot the 4th core went out of screen).

:question: How to deal with the "ts" translation files? Aren't those generated by Transifex?

Sailfish Version: 3.0.0.8 Device: Fairphone 2

CPU view preview:

Landscape Portrait
lighthouse_cpu_landscape lighthouse_cpu_portrait
almindor commented 5 years ago

ts files are generated by transifex (except the base english ones) but the build shouldn't really "lose" translations. You might see them updated due to line # changes but that's ok.

I'll test this branch during the weekend and merge if all good. Thanks for the work!

almindor commented 5 years ago

Thank you very much! looking good. Will release soon