search

almindor / mipidsi

MIPI Display Serial Interface unified driver
MIT License
108 stars 47 forks source link

fix spi st7789 example for v0.8 #117

Closed almindor closed 2 months ago

almindor commented 4 months ago

This is the only one I know how to fix, the others hal packages don't seem to be at eh1 yet.

Related to #99

NOTE: this cannot be merged until v0.8 is released

rfuest commented 4 months ago

This is the only one I know how to fix, the others hal packages don't seem to be at eh1 yet.

I don't know about the ESP32 one, but there is e-h 1 support for the pico. The feature to enable support is still called eh1_0_alpha, but the latest release uses the final version of e-h 1.

NOTE: this cannot be merged until v0.8 is released

Because CI is failing? We will need to change CI anyway to make sure it uses the latest development version to build the examples. The simplest solution would be to use path dependencies in the examples. But this would make anyone how just wants to try one of the examples also use the latest development version. I'm not sure if that's a problem, but all solutions I can come up with have some drawback.

rursprung commented 3 months ago

I don't know about the ESP32 one

you can use the eh1 feature on the latest version of the HAL

Because CI is failing? We will need to change CI anyway to make sure it uses the latest development version to build the examples. The simplest solution would be to use path dependencies in the examples. But this would make anyone how just wants to try one of the examples also use the latest development version. I'm not sure if that's a problem, but all solutions I can come up with have some drawback.

IMHO the path dependency is the best way for such examples - it ensures that you examples always match what's currently in the repo (and anyone looking at the examples is looking at the repo). it's really confusing if the two don't match.

almindor commented 2 months ago

superseded