search

almindor / mipidsi

MIPI Display Serial Interface unified driver
MIT License
108 stars 46 forks source link

Optional RST handling #3

Closed pyaillet closed 2 years ago

pyaillet commented 2 years ago

Hi !

I was able to use this driver for a TTGO Display with st7789. However there is no RST pin on the TTGO T-Watch. I would like to propose some changes to this driver to handle the absence of the RST Pin.

Would you prefer handling this by wrapping the RST Pin in an Option ? Creating different models ? Another approach ?

almindor commented 2 years ago

Good question. I wonder if this should be handled by the DisplayInterface instead. That'd be a big change tho, for now I think we should make it optional somehow.

The issue is using just Option<RST> doesn't solve it because it still requires the type to be OutputPin of some kind. So even if you're passing None you'd have to specify the type. We could possibly add a constructor that uses some sort of dummy OutputPin type internally so users can avoid that issue I guess.

pyaillet commented 2 years ago

Let's close this one two as the PR was merged :)

Thanks again !