almindor / mipidsi

MIPI Display Serial Interface unified driver
MIT License
108 stars 46 forks source link

add the support for displays without a RST pin #4

Closed pyaillet closed 2 years ago

pyaillet commented 2 years ago

The choice was made here to rely on an internal NoPin implementation to hide the details and expose it as an Alias type.

Proposal fix for #3

It would be used like this :

let display = DisplayNoRST::st7789_without_rst(di);

And it would be defined as:

  pub struct Twatch<'a> {
      pmu: Pmu<'a>,
      display: DisplayNoRST<EspSpi2InterfaceNoCS, mipidsi::models::ST7789>,
      [...]
  }
pyaillet commented 2 years ago

Many thanks for the review :)

I removed the init seq from this PR and most of the comments shoulds be resolved now.