Closed Slushee-a closed 11 months ago
I see what went wrong.
I will fix this in my next commit very soon
I'm really sorry... This is embarassing. Sorry for wasting your time. Apparently it failed because some trailing spaces? otherwise I can't see what made the pipeline failed. Fixed in the latest commit.
I'm really sorry... This is embarassing. Sorry for wasting your time. Apparently it failed because some trailing spaces? otherwise I can't see what made the pipeline failed. Fixed in the latest commit.
No problem at all. You're giving something to improve the library, there's nothing to feel sorry or embarrased about.
Made this merge request as mentioned in #64.
Why
Coming into the crate I wasn't sure where
DisplayInterface
andRgb565
came from, as well as which modules I needed to import. Browsing through different crate docs and looking at clippy helps you figure out all of that, but adding more, and less simplified examples saves you most of that trouble.Changes included
display-interface
crates that can be used to create theDisplayInterface
.orientation()
and.setpixel()
Builder
docs page/examples
folder (Contains an example for the pi pico with the ili9341)Could be improved:
display.set_pixels()
(It's not very clear what "anything that can provideIntoIterator<Item = u16>
" is supposed to be)display.set_scroll_region()
isn't very extensive/clear/examples
folder with another display, microcontroller and interface used. Could also include a more advanced drawing rather than just the whole screen being one color. A colored square would be nice.