Here is how it would look if we used maybe-async-cfg to handle sync and async code, see the doc for macro here.
Mainly we just compile and change the identifier for the async ones and we end up with a async and sync variant of each trait and struct. Ex: The lib would have an DisplayAsync and Display struct.
I havent completed all the impl for all the displays since I wanted your feedback beforehand and didn't want to overload the PR with noise. Currently, only the GC9A01 is implemented but it would be pretty much the same for all models.
Note that I've updated embedded-hal and I'm currently using the git version of display-interface since the release with async support was not created yet.
xgroleau
commented
1 year ago
Here is how it would look if we used maybe-async-cfg to handle sync and async code, see the doc for macro here.
Mainly we just compile and change the identifier for the async ones and we end up with a async and sync variant of each trait and struct. Ex: The lib would have an
DisplayAsyncandDisplaystruct.I havent completed all the impl for all the displays since I wanted your feedback beforehand and didn't want to overload the PR with noise. Currently, only the
GC9A01is implemented but it would be pretty much the same for all models.Note that I've updated
embedded-haland I'm currently using the git version ofdisplay-interfacesince the release with async support was not created yet.