search

almindor / mipidsi

MIPI Display Serial Interface unified driver
MIT License
108 stars 47 forks source link

Expose Display.dcs #89

Closed sampaioletti closed 5 months ago

sampaioletti commented 5 months ago

Would it be feasible to expose the internal Dcs somehow?

i.e.

  1. Make it public
  2. Add a pass-through "write_raw" method to the Display struct
  3. Implement a trait that exposes that functionality so that specific expansion methods could be created for each model outside of the shared abstraction.

Interested in sending custom commands to a ST7789.

Thanks for the lib...using it successfully (:

almindor commented 5 months ago

Sure, this isn't a problem, I'll add it for the next release

sampaioletti commented 5 months ago

Awesome thanks. Sorry meant to offer a PR.

-Sam

From: Aleš Katona @.> Sent: Saturday, January 13, 2024 12:02:07 PM To: almindor/mipidsi @.> Cc: sam @.>; Author @.> Subject: Re: [almindor/mipidsi] Expose Display.dcs (Issue #89)

Closed #89https://github.com/almindor/mipidsi/issues/89 as completed via #90https://github.com/almindor/mipidsi/pull/90.

— Reply to this email directly, view it on GitHubhttps://github.com/almindor/mipidsi/issues/89#event-11478658486, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ACDGQ57YTWBFMCERDGTQ373YOLK27AVCNFSM6AAAAABBXGHAOWVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJRGQ3TQNRVHA2DQNQ. You are receiving this because you authored the thread.Message ID: @.***>