search

almindor / mipidsi

MIPI Display Serial Interface unified driver
MIT License
108 stars 47 forks source link

make Display::dcs public, fixes #89 #90

Closed almindor closed 5 months ago

almindor commented 5 months ago

Add Display::dcs unsafe method to allow sending custom commands. Fixes #89

rfuest commented 5 months ago

I don't really like this change. If the user can send any command to the display it is possible to leave the controller in any state and possibly break further commands that are send using the regular API. I would prefer to only expose the DCS interface as an unsafe getter, if this function is really required and there is no way to add a higher level API to achieve the same function.

almindor commented 5 months ago

@rfuest changed it into an unsafe getter method, lmk if this is ok.