almindor / mipidsi

MIPI Display Serial Interface unified driver
MIT License
108 stars 47 forks source link

Remove toplevel re-exports #95

Closed rfuest closed 5 months ago

rfuest commented 5 months ago

I was just checking something in the docs and noticed the re-export section in the root of the create docs. Should we perhaps remove these re-exports?

I don't see the point of having the options available as e.g. mipidsi::ColorOrder and mipidsi::options::ColorOrder. Removing the re-export would keep the root namespace clean. And, from a docs point of view, the types wouldn't be any less discoverable, because the options::* re-export only links to the options module and doesn't give a full list of available types.

The error module is similar and I don't think there is a good reason for only re-exporting on of the two error types. Without the re-export all error types could be found in a single place.