almindor / st7789

Rust library for displays using the ST7735 driver
https://docs.rs/st7735-lcd
MIT License
47 stars 24 forks source link

Unused buffer feature #12

Closed rfuest closed 3 years ago

rfuest commented 3 years ago

The buffer feature isn't used at the moment, but still mentioned in the documentation. It seems to have been unused since PR #10.

almindor commented 3 years ago

I believe this is wrong? You can see here that draw_iter will use batching if the feature is enabled. So say circles or such. I tested with embedded-counters and got these results with the shapes example:

# without batch feature
{
  "cmd": {
    "iterations": 4582,
    "bytes": 4582
  },
  "data": {
    "iterations": 7624,
    "bytes": 185039
  }
}

# with batch feature
{
  "cmd": {
    "iterations": 3802,
    "bytes": 3802
  },
  "data": {
    "iterations": 6324,
    "bytes": 182959
  }
}
rfuest commented 3 years ago

This issue is about the buffer and not the batch feature.

almindor commented 3 years ago

This issue is about the buffer and not the batch feature.

:doh: yeah, I forgot about that one completely, removed. Thanks.