Refactor driver to provide a standard SPI display_interface for embedded hal

almindor / st7789

Rust library for displays using the ST7735 driver

https://docs.rs/st7735-lcd

MIT License

49 stars 25 forks source link

Refactor driver to provide a standard SPI display_interface for embedded hal #3

Closed tstellanova closed 4 years ago

tstellanova commented 4 years ago

Borrow delay source rather than taking ownership of it
Implement display_interface and provide a builder method
Take ownership of CSX pin and simplify GPIO pin error handling

tstellanova commented 4 years ago

I believe I included most of @therealprof changes from #1 but also:

borrow the delay source rather than taking ownership of it
provide a convenience function for creating an SPI interface (the only option for this particular device)

therealprof commented 4 years ago

@tstellanova I've an update to the display-interface sitting around for a while now which I'm hoping to release very soon now. It changes a few aspects of the interface and will interfere with this PR. If you'd like have a look and do some changes I can prepare a branch with it.

tstellanova commented 4 years ago

@therealprof Sounds good, I’d love to take a look. This PR is part of a PineTime bootstrap effort.

therealprof commented 4 years ago

@tstellanova https://crates.io/crates/display-interface 0.2.0 released and https://github.com/almindor/st7789/pull/1 updated accordingly.

almindor commented 4 years ago

I've just released 0.2.3 with the new clear() as "last before display interface" version. Will review/test this tonight or tomorrow hopefully and merge in. Thanks!

almindor commented 4 years ago

Thank you both! This is great.

dbrgn commented 4 years ago

Borrow delay source rather than taking ownership of it

That's awesome, fixes one of the annoyances I had when working with this lib on RTFM. (It could be worked around by using a timer based delay source though.)

This PR is part of a PineTime bootstrap effort.

@tstellanova: Where are these efforts happening? My work is happening here: https://github.com/dbrgn/pinetime-rtfm/ I'd be happy to join forces.

tstellanova commented 4 years ago

Borrow delay source rather than taking ownership of it

That's awesome, fixes one of the annoyances I had when working with this lib on RTFM. (It could be worked around by using a timer based delay source though.)

This PR is part of a PineTime bootstrap effort.

@tstellanova: Where are these efforts happening? My work is happening here: https://github.com/dbrgn/pinetime-rtfm/ I'd be happy to join forces.

@dbrgn In a few different places. I've mostly been focused on embedded-HAL drivers for supporting the various sensors and such on the PineTime, and have built a bare metal application to test out the drivers. I've also been supporting Jay Kickliter and friends who are working on a port of Tock OS to this hardware.