search

almond-bongbong / react-slot-counter

🚀 Elevate Your UI with Dynamic, Eye-Catching Counters
https://almond-bongbong.github.io/react-slot-counter/
112 stars 12 forks source link

Infinite dummy list #2

Closed blzpedro closed 1 year ago

blzpedro commented 1 year ago

Hey, I was taking a look into your lib then I thought of one suggestion, you could create an "infinite" dummy list with the real value centralized just adding the dummy list to the bottom.

What do you think?

almond-bongbong commented 1 year ago

Thank you very much for your suggestion! I appreciate your input, and I'll start working on implementing this feature right away. 🙂

blzpedro commented 1 year ago

Nice, thanks!

I'm trying to implement this and if it works I open a PR for your repo!

Just to let you know, I had this idea because I tried to add some styles to the chars and realized the empty bottom space.

blzpedro commented 1 year ago

Hey, I opened a PR https://github.com/almond-bongbong/react-slot-counter/pull/3, can you see it there?

almond-bongbong commented 1 year ago

Yes, thank you! I'll check out the PR.

blzpedro commented 1 year ago

Seems that it's resolved. Added the prop hasInfiniteList.