search

almond-sh / almond

A Scala kernel for Jupyter
https://almond.sh
BSD 3-Clause "New" or "Revised" License
1.6k stars 238 forks source link

Unbound most queues #1159

Closed alexarchambault closed 1 year ago

alexarchambault commented 1 year ago

It doesn't really make sense for us to bound queues here… they all get filled after actions users manually took (like doing "Run all cells" in a notebook with x hundreds cells…), so we can't really get flooded and crash because of that - we're not a web service treating 1000s of req / s…

Doing this to address a possible deadlock I've been seeing with the new launcher, with a "Run all cells" in a large notebook (> 50 cells, former size of most bounded queues in Almond) deadlocking things.

alexarchambault commented 1 year ago

It should be possible to actually add an integration tests for that… 🤔