search

almond-sh / almond

A Scala kernel for Jupyter
https://almond.sh
BSD 3-Clause "New" or "Revised" License
1.59k stars 239 forks source link

revert to cmd for the wrapper name #1349

Closed coreyoconnor closed 4 months ago

coreyoconnor commented 5 months ago

This is the name expected by Spark.

coreyoconnor commented 4 months ago

sounds good! I might have some time to devote. I'll post a draft-PR for extending the integration tests if I get started.

Adding the link to similar code in spark for future reference: https://github.com/apache/spark/blob/master/connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/application/ConnectRepl.scala#L116

coreyoconnor commented 4 months ago

I'm able to reproduce the integration test failures locally. Will update the PR shortly.