search

almondyoung / libyuv

Automatically exported from code.google.com/p/libyuv
BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

MIPSDSPr2 build issues #398

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
Chromium's change in the build system that introduces the MIPS DSP ASE support 
(https://codereview.chromium.org/883253003/). 

Since the build system for MIPS DSPR2 (mips_dsp_rev=2) adds -mdspr2 into the 
CFLAGS, we have come across some build issues concerning the libyuv MIPS DSPR2 
code.

../../chromium/src/third_party/libyuv/source/planar_functions.cc: In function 
void libyuv::MirrorPlane(const uint8*, int, uint8*, int, int, int):
../../chromium/src/third_party/libyuv/source/planar_functions.cc:277:18: error: 
src was not declared in this scope
       IS_ALIGNED(src, 4) && IS_ALIGNED(src_stride, 4) &&
                  ^
../../chromium/src/third_party/libyuv/source/planar_functions.cc:277:40: error: 
src_stride was not declared in this scope
       IS_ALIGNED(src, 4) && IS_ALIGNED(src_stride, 4) &&
                                        ^
../../chromium/src/third_party/libyuv/source/planar_functions.cc:278:18: error: 
dst was not declared in this scope
       IS_ALIGNED(dst, 4) && IS_ALIGNED(dst_stride, 4)) {
                  ^
../../chromium/src/third_party/libyuv/source/planar_functions.cc:278:40: error: 
dst_stride was not declared in this scope
       IS_ALIGNED(dst, 4) && IS_ALIGNED(dst_stride, 4)) {
                                        ^

../../chromium/src/third_party/libyuv/source/scale_common.cc: In function void 
libyuv::ScalePlaneVertical(int, int, int, int, int, const uint8*, uint8*, int, 
int, int, int, libyuv::FilterMode):
../../chromium/src/third_party/libyuv/source/scale_common.cc:923:22: error: 
InterpolateRow_Any_MIPS_DSPR2 was not declared in this scope
     InterpolateRow = InterpolateRow_Any_MIPS_DSPR2;
                      ^
../../chromium/src/third_party/libyuv/source/scale_common.cc:925:24: error: 
InterpolateRow_MIPS_DSPR2 was not declared in this scope
       InterpolateRow = InterpolateRow_MIPS_DSPR2;

../../chromium/src/third_party/libyuv/source/planar_functions.cc: In function 
int libyuv::ARGBInterpolate(const uint8*, int, const uint8*, int, uint8*, int, 
int, int, int):
../../chromium/src/third_party/libyuv/source/planar_functions.cc:1848:5: error: 
ScaleARGBFilterRows was not declared in this scope
     ScaleARGBFilterRows = InterpolateRow_MIPS_DSPR2;
     ^

Original issue reported on code.google.com by fbarch...@google.com on 7 Feb 2015 at 12:31

GoogleCodeExporter commented 8 years ago 
Fixed in r1268
https://webrtc-codereview.appspot.com/37999004

Original comment by fbarch...@google.com on 7 Feb 2015 at 1:04