almosr / android-svg-code-render

Convert SVG files into Java source and use it in your Android app
Apache License 2.0
24 stars 3 forks source link

SVG.getFromResource(Resources, int) - patch included #16

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Hello Paul,

This is more a suggestion than an issue. It think it would be nice if the SVG 
class had an additional getFromResource() method that takes a Resources object 
instead of a Context object. This would make the library a bit more flexible to 
integrate in existing code (at least in my case).

Here's a patch: 
https://code.google.com/r/matthiasstevens-androidsvg/source/detail?r=55dded6515d
5b1aacf4b5ccb66c6d24de0dd0b53

Could you please include this in your next release?

Best & thanks in advance,

Matthias

Original issue reported on code.google.com by matthias...@gmail.com on 22 Aug 2013 at 11:37

GoogleCodeExporter commented 9 years ago

Original comment by paul.leb...@gmail.com on 22 Aug 2013 at 1:53

GoogleCodeExporter commented 9 years ago
Fixed in revision 247.

Added an SVG.getFromResource() variant that takes a Resources object rather 
than a Context.

Thanks for the patch Matthias.  This change will be in release 1.3.0.

Original comment by paul.leb...@gmail.com on 22 Aug 2013 at 1:55

GoogleCodeExporter commented 9 years ago

Original comment by paul.leb...@gmail.com on 22 Aug 2013 at 1:55

GoogleCodeExporter commented 9 years ago
This fix is available in the 1.2.1 release.

Original comment by paul.leb...@gmail.com on 31 Jan 2014 at 1:32