search

almost-matching-exactly / DAME-FLAME-Python-Package

A Python Package providing two algorithms, DAME and FLAME, for fast and interpretable treatment-control matches of categorical data
https://almost-matching-exactly.github.io/DAME-FLAME-Python-Package/
MIT License
57 stars 14 forks source link

[WIP] Bticknor refactor #1

Closed bticknor closed 3 years ago

bticknor commented 4 years ago

No need to merge this - just opening a PR to help keep track of my changes. I'm thinking of using this algorithm for something and am trying to clean up the code a little, notably by relying on Python's configparser library to parse arguments for the main routines, fixing the types of some arguments (adaptive_weights, e.g.), and just general refactoring.

nehargupta commented 4 years ago

Hello @bticknor,

Hope you're doing well. It's been a few months, so I wanted to check in. Is your team still hoping to use the package? If you were able to use it and wanted to share your experiences, I think the team would be interested to hear about it. Or, if you were waiting to see any additional changes, please let me know. Feel free to send me a personal email as well.

These changes are probably all in conflict at this point since the package underwent several changes since the winter, but I don't want to close this request in case it's still valuable to you.

Thanks, Neha

nehargupta commented 3 years ago

Closing this as so much has changed since it's original work and the code is wayyyy cleaner. Thanks for the suggestions @bticknor , your future contributions are also welcome!