BUG: Off-by-1 error in reporting stopping / iteration counting?

almost-matching-exactly / DAME-FLAME-Python-Package

A Python Package providing two algorithms, DAME and FLAME, for fast and interpretable treatment-control matches of categorical data

https://almost-matching-exactly.github.io/DAME-FLAME-Python-Package/

MIT License

56 stars 14 forks source link

BUG: Off-by-1 error in reporting stopping / iteration counting? #32

Closed nickeubank closed 3 years ago

nickeubank commented 3 years ago

I think the iteration counter may be using human indices (starting at 1) while the arguments use 0-counting, leading to confusing printouts (compare top and last lines?):

nickeubank commented 3 years ago

After playing around, I think the text error should just say "after doing". Will PR.