Testing: Ensure that DAME consistent with R-DAME

almost-matching-exactly / DAME-FLAME-Python-Package

A Python Package providing two algorithms, DAME and FLAME, for fast and interpretable treatment-control matches of categorical data

https://almost-matching-exactly.github.io/DAME-FLAME-Python-Package/

MIT License

56 stars 14 forks source link

Testing: Ensure that DAME consistent with R-DAME #39

Closed nehargupta closed 3 years ago

nehargupta commented 3 years ago

Working on this now, aim is to complete by end of this month, will definitely go out in the release coming out before July. It looks like there was a case in which this dame-flame Python package was ending one iteration too early, and that has been resolved now with #34. Doing more testing to ensure no other issues now.

nehargupta commented 3 years ago

This appears to be fine whenever repeats=False. Still working through issues in repeats=True.

Tommy has a great comparison file that could get integrated in the test suite at some point if we wanted an enhancement.

nehargupta commented 3 years ago

All looks good after lots of testing done. Will close this for now, we can re-open when/if we decide to integrate Tommy's test suite here (I actually think the better place is in it's own repo, since it uses both R code and Python code).