Rehaul API design to avoid needing as many arguments

almost-matching-exactly / DAME-FLAME-Python-Package

A Python Package providing two algorithms, DAME and FLAME, for fast and interpretable treatment-control matches of categorical data

https://almost-matching-exactly.github.io/DAME-FLAME-Python-Package/

MIT License

57 stars 14 forks source link

Rehaul API design to avoid needing as many arguments #9

Closed nehargupta closed 3 years ago

nehargupta commented 4 years ago

https://github.com/almost-matching-exactly/DAME-FLAME-Python-Package/blob/51748f54e7a2fadbfb986d0b4ad96a98987f4a22/dame_flame/DAME_FLAME.py#L226

If this API was designed in a more class-like structure and stored return_df and input_df as private variables, then these functions wouldn't need to pass them in as parameters.

nehargupta commented 3 years ago

while doing this, get rid of the want_pe and want_bf arguments and make those into separate functions, I think

nehargupta commented 3 years ago

done. might need a re-review or two from the rest of the team but looks good to me