search

almost / react-native-html-webview

Display HTML in a UIWebView, optionally sanitizing it first
MIT License
105 stars 20 forks source link

add support for transparent backgroundColor of WebView #14

Closed millerized closed 7 years ago

millerized commented 8 years ago

This is handled the same way in RCTWebView. ref: https://github.com/facebook/react-native/blob/master/React/Views/RCTWebView.m#L109-#L119

almost commented 8 years ago

This will also need some code in the manager class and in the JS code to work won't it?

millerized commented 8 years ago

No I don't believe so. Since backgroundColor is already a valid styles prop-type, and any subclass of RCTView is already set up to be forwarded props via convential setters, I think simply the presence of a -setBackgroundColor: implementation ought to be sufficient.

millerized commented 7 years ago

Closing this because this component is no longer useful now that we've had better WebView components for quite some time.