almostEric / Frequency-Domain

Frequency domain based modules for VCV Rack
Other
2 stars 1 forks source link

Compile failure #1

Open cschol opened 2 weeks ago

cschol commented 2 weeks ago

Compile failure when building with rack-plugin-toolchain:

In file included from src/controller/BoxOfRevelation.cpp:1:                                                                                                                                                                                                                        
In file included from src/controller/BoxOfRevelation.hpp:8:                                                                                                                                                                                                                        
In file included from src/controller/../model/dsp/filter/NonlinearBiquad.hpp:18:                                                                                                                                                                                                   
src/controller/../model/dsp/filter/Biquad.hpp:27:10: fatal error: 'simd/vector.hpp' file not found                                                                                                                                                                                 
#include <simd/vector.hpp>                                                                                                                                                                                                                                                         
         ^~~~~~~~~~~~~~~~~                                                                                                                                                                                                                                                         
In file included from src/controller/DanceThisMeshAround.cpp:1:                                                                                                                                                                                                                    
In file included from src/controller/DanceThisMeshAround.hpp:3:                                                                                                                                                                                                                    
In file included from src/controller/../model/dsp/filter/NonlinearBiquad.hpp:18:                                                                                                                                                                                                   
src/controller/../model/dsp/filter/Biquad.hpp:27:10: fatal error: 'simd/vector.hpp' file not found                                                                                                                                                                                 
#include <simd/vector.hpp>                                                                                                                                                                                                                                                         
         ^~~~~~~~~~~~~~~~~                                           **
almostEric commented 1 week ago

the vector.hpp file is located in Rack under include/simd. This compiles fine on my machine. If this is not the correct location, where should it be?

cschol commented 1 week ago

This patch will make it compile:

diff --git a/src/model/dsp/filter/ChebyshevI.hpp b/src/model/dsp/filter/ChebyshevI.hpp
index 7ed5e33..e649163 100644
--- a/src/model/dsp/filter/ChebyshevI.hpp
+++ b/src/model/dsp/filter/ChebyshevI.hpp
@@ -5,11 +5,11 @@
 //#include "Filter.hpp"

 #include <cmath>
-#include <simd/vector.hpp>
-#include <simd/sse_mathfun.h>
-#include <simd/sse_mathfun_extension.h>
+//#include <simd/vector.hpp>
+//#include <simd/sse_mathfun.h>
+//#include <simd/sse_mathfun_extension.h>

-using rack::simd::float_4;
+//using rack::simd::float_4;

 enum {
diff --git a/src/model/dsp/filter/CombFilter.hpp b/src/model/dsp/filter/CombFilter.hpp
index a03ab87..f5fd9a1 100644
--- a/src/model/dsp/filter/CombFilter.hpp
+++ b/src/model/dsp/filter/CombFilter.hpp
@@ -6,11 +6,11 @@

 #include <cmath>
 #include "../../DelayLine.hpp"
-#include <simd/vector.hpp>
-#include <simd/sse_mathfun.h>
-#include <simd/sse_mathfun_extension.h>
+//#include <simd/vector.hpp>
+//#include <simd/sse_mathfun.h>
+//#include <simd/sse_mathfun_extension.h>

-using rack::simd::float_4;
+//using rack::simd::float_4;
cschol commented 1 week ago

This is in addition to the changes in 89db78a27d364d88f76953ab41e80d9eef53a5b6.