Problems with unit tests / what unit tests revealed

[almostintuitive]

originally by @fabb :

https://github.com/itchingpixels/talks/pull/4#issuecomment-185103420

these are the open problems with the reactive versions:

• If one gesture recognizer starts and ends, and then the other starts, the timer is started, but it should not (testBeganPanEndedPanBeganRotateGesture)
• The last Tick and Completed happen immediately after each other, in the imperative version there is a second time between
• The timer counts up, not down like the imperative version
• It leaks (#5), maybe we can unit test this via RxSwift.resourceCount

Currently 2 problems exist with the unit tests:

• Cannot use Variable for MockReactiveTimer, as Variable sends the first value immediately, but we need it to wait until the first call to mockExecuteOnTick (I asked at the RxSwift project for some advice on this ReactiveX/RxSwift#490)
• Cannot use XCTAssertNil(mockTimer) at the moment, as we need to retain the mockTimer, as it is not directly provided as Observable to the sut

[almostintuitive]

I'm thinking if we could fix the problem with Variable by using the skip operator?

[fabb]

Cool, I can edit other's posts ;-) skip could work for fixing the unit tests. But it would not fix the XCTAssertNil(mockTimer) issue. Let's see, maybe someone in the linked RxSwift issue has an idea. Meanwhile we could try skip.

[almostintuitive]

this may also come handy: https://github.com/ReactiveX/RxSwift/tree/master/RxTests