search

alnitak / flutter_soloud

Flutter low-level audio plugin using SoLoud C++ library and FFI
MIT License
209 stars 21 forks source link

chore: Address C++ compilation warnings #48

Closed filiph closed 6 months ago

filiph commented 6 months ago

Description

Currently, every new build of a Flutter project that depends on flutter_soloud will generate a large number of warnings (full listing below).

Screenshot 2024-03-14 at 15 51 56

This does not have any effect on functionality, it seems, but it would still be a much better experience if there were no warnings.

Log output

In file included from /Users/filiph/.pub-cache/hosted/pub.dev/flutter_soloud-2.0.0-pre.2/macos/Classes/flutter_soloud.mm:3:
In file included from /Users/filiph/.pub-cache/hosted/pub.dev/flutter_soloud-2.0.0-pre.2/macos/Classes/../../src/flutter_soloud.cpp:31:
/Users/filiph/dev/flutter-codelabs/audio_soloud/soloud_game/macos/Flutter/ephemeral/.symlinks/plugins/flutter_soloud/src/soloud/src/core/soloud_thread.cpp:225:30: warning: implicit conversion loses integer precision: '__darwin_time_t' (aka 'long') to 'int' [-Wshorten-64-to-32]
                        return spec.tv_sec * 1000 + (int)(spec.tv_nsec / 1.0e6);
                        ~~~~~~ ~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /Users/filiph/.pub-cache/hosted/pub.dev/flutter_soloud-2.0.0-pre.2/macos/Classes/flutter_soloud.mm:3:
In file included from /Users/filiph/.pub-cache/hosted/pub.dev/flutter_soloud-2.0.0-pre.2/macos/Classes/../../src/flutter_soloud.cpp:38:
/Users/filiph/dev/flutter-codelabs/audio_soloud/soloud_game/macos/Flutter/ephemeral/.symlinks/plugins/flutter_soloud/src/soloud/src/audiosource/ay/sndchip.cpp:35:96: warning: implicit conversion loses integer precision: 'long long' to 'unsigned int' [-Wshorten-64-to-32]
        unsigned end_chip_tick = ((passed_clk_ticks + (long long)clk_ticks) * chip_clock_rate) / system_clock_rate;
                 ~~~~~~~~~~~~~   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~
/Users/filiph/dev/flutter-codelabs/audio_soloud/soloud_game/macos/Flutter/ephemeral/.symlinks/plugins/flutter_soloud/src/soloud/src/audiosource/ay/sndchip.cpp:48:29: warning: possible misuse of comma operator here [-Wcomma]
      if (++ta >= fa) ta = 0, bitA ^= -1;
                            ^
      if (++ta >= fa) ta = 0, bitA ^= -1;
                      ^~~~~~
                      static_cast<void>( )
/Users/filiph/dev/flutter-codelabs/audio_soloud/soloud_game/macos/Flutter/ephemeral/.symlinks/plugins/flutter_soloud/src/soloud/src/audiosource/ay/sndchip.cpp:49:29: warning: possible misuse of comma operator here [-Wcomma]
      if (++tb >= fb) tb = 0, bitB ^= -1;
                            ^
      if (++tb >= fb) tb = 0, bitB ^= -1;
                      ^~~~~~
                      static_cast<void>( )
/Users/filiph/dev/flutter-codelabs/audio_soloud/soloud_game/macos/Flutter/ephemeral/.symlinks/plugins/flutter_soloud/src/soloud/src/audiosource/ay/sndchip.cpp:50:29: warning: possible misuse of comma operator here [-Wcomma]
      if (++tc >= fc) tc = 0, bitC ^= -1;
                            ^
      if (++tc >= fc) tc = 0, bitC ^= -1;
                      ^~~~~~
                      static_cast<void>( )
/Users/filiph/dev/flutter-codelabs/audio_soloud/soloud_game/macos/Flutter/ephemeral/.symlinks/plugins/flutter_soloud/src/soloud/src/audiosource/ay/sndchip.cpp:52:16: warning: possible misuse of comma operator here [-Wcomma]
         tn = 0,
               ^
         tn = 0,
         ^~~~~~
         static_cast<void>( )
/Users/filiph/dev/flutter-codelabs/audio_soloud/soloud_game/macos/Flutter/ephemeral/.symlinks/plugins/flutter_soloud/src/soloud/src/audiosource/ay/sndchip.cpp:53:51: warning: possible misuse of comma operator here [-Wcomma]
         ns = (ns*2+1) ^ (((ns>>16)^(ns>>13)) & 1),
                                                  ^
         ns = (ns*2+1) ^ (((ns>>16)^(ns>>13)) & 1),
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
         static_cast<void>(                       )
/Users/filiph/dev/flutter-codelabs/audio_soloud/soloud_game/macos/Flutter/ephemeral/.symlinks/plugins/flutter_soloud/src/soloud/src/audiosource/ay/sndchip.cpp:56:16: warning: possible misuse of comma operator here [-Wcomma]
         te = 0, env += denv;
               ^
         te = 0, env += denv;
         ^~~~~~
         static_cast<void>( )
/Users/filiph/dev/flutter-codelabs/audio_soloud/soloud_game/macos/Flutter/ephemeral/.symlinks/plugins/flutter_soloud/src/soloud/src/audiosource/ay/sndchip.cpp:64:33: warning: possible misuse of comma operator here [-Wcomma]
               denv = -(int)denv, env = env + denv;
                                ^
               denv = -(int)denv, env = env + denv;
               ^~~~~~~~~~~~~~~~~
               static_cast<void>( )
/Users/filiph/dev/flutter-codelabs/audio_soloud/soloud_game/macos/Flutter/ephemeral/.symlinks/plugins/flutter_soloud/src/soloud/src/audiosource/ay/sndchip.cpp:65:26: warning: possible misuse of comma operator here [-Wcomma]
            else env = 31, denv = 0; //11,13
                         ^
            else env = 31, denv = 0; //11,13
                 ^~~~~~~~
                 static_cast<void>( )
/Users/filiph/dev/flutter-codelabs/audio_soloud/soloud_game/macos/Flutter/ephemeral/.symlinks/plugins/flutter_soloud/src/soloud/src/audiosource/ay/sndchip.cpp:148:32: warning: possible misuse of comma operator here [-Wcomma]
         if (r.env & 4) env = 0, denv = 1; // attack
                               ^
         if (r.env & 4) env = 0, denv = 1; // attack
                        ^~~~~~~
                        static_cast<void>( )
/Users/filiph/dev/flutter-codelabs/audio_soloud/soloud_game/macos/Flutter/ephemeral/.symlinks/plugins/flutter_soloud/src/soloud/src/audiosource/ay/sndchip.cpp:149:23: warning: possible misuse of comma operator here [-Wcomma]
         else env = 31, denv = -1; // decay
                      ^
         else env = 31, denv = -1; // decay
              ^~~~~~~~
              static_cast<void>( )
In file included from /Users/filiph/.pub-cache/hosted/pub.dev/flutter_soloud-2.0.0-pre.2/macos/Classes/flutter_soloud.mm:3:
In file included from /Users/filiph/.pub-cache/hosted/pub.dev/flutter_soloud-2.0.0-pre.2/macos/Classes/../../src/flutter_soloud.cpp:39:
/Users/filiph/dev/flutter-codelabs/audio_soloud/soloud_game/macos/Flutter/ephemeral/.symlinks/plugins/flutter_soloud/src/soloud/src/audiosource/ay/sndrender.cpp:38:18: warning: possible misuse of comma operator here [-Wcomma]
        mix_l = l, mix_r = r;
                 ^
        mix_l = l, mix_r = r;
        ^~~~~~~~~
        static_cast<void>( )
/Users/filiph/dev/flutter-codelabs/audio_soloud/soloud_game/macos/Flutter/ephemeral/.symlinks/plugins/flutter_soloud/src/soloud/src/audiosource/ay/sndrender.cpp:45:103: warning: implicit conversion loses integer precision: 'long long' to 'unsigned int' [-Wshorten-64-to-32]
        unsigned endtick = ((passed_sys_ticks + endframe_sys_tick) * (long long)sample_rate * TICK_F) / sys_clock_rate;
                 ~~~~~~~   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~
/Users/filiph/dev/flutter-codelabs/audio_soloud/soloud_game/macos/Flutter/ephemeral/.symlinks/plugins/flutter_soloud/src/soloud/src/audiosource/ay/sndrender.cpp:120:45: warning: possible misuse of comma operator here [-Wcomma]
                                s2_l = val_l, s2_r = val_r; // s2=s1, s1=0;
                                            ^
                                s2_l = val_l, s2_r = val_r; // s2=s1, s1=0;
                                ^~~~~~~~~~~~
                                static_cast<void>( )
In file included from /Users/filiph/.pub-cache/hosted/pub.dev/flutter_soloud-2.0.0-pre.2/macos/Classes/flutter_soloud.mm:3:
In file included from /Users/filiph/.pub-cache/hosted/pub.dev/flutter_soloud-2.0.0-pre.2/macos/Classes/../../src/flutter_soloud.cpp:40:
In file included from /Users/filiph/dev/flutter-codelabs/audio_soloud/soloud_game/macos/Flutter/ephemeral/.symlinks/plugins/flutter_soloud/src/soloud/src/audiosource/ay/soloud_ay.cpp:35:
/Users/filiph/dev/flutter-codelabs/audio_soloud/soloud_game/macos/Flutter/ephemeral/.symlinks/plugins/flutter_soloud/src/soloud/include/zx7decompress.h:70:23: warning: '&' within '|' [-Wbitwise-op-parentheses]
        return (value & 127 | i << 7) + 128;
                ~~~~~~^~~~~ ~
        return (value & 127 | i << 7) + 128;
                      ^
                (          )
/Users/filiph/dev/flutter-codelabs/audio_soloud/soloud_game/macos/Flutter/ephemeral/.symlinks/plugins/flutter_soloud/src/soloud/include/zx7decompress.h:81:30: warning: implicit conversion loses integer precision: 'size_t' (aka 'unsigned long') to 'int' [-Wshorten-64-to-32]
        i = io->output_index - offset;
          ~ ~~~~~~~~~~~~~~~~~^~~~~~~~
/Users/filiph/dev/flutter-codelabs/audio_soloud/soloud_game/macos/Flutter/ephemeral/.symlinks/plugins/flutter_soloud/src/soloud/include/zx7decompress.h:104:27: warning: implicit conversion loses integer precision: 'size_t' (aka 'unsigned long') to 'int' [-Wshorten-64-to-32]
                return io.input_index;
                ~~~~~~ ~~~^~~~~~~~~~~
In file included from /Users/filiph/.pub-cache/hosted/pub.dev/flutter_soloud-2.0.0-pre.2/macos/Classes/flutter_soloud.mm:3:
In file included from /Users/filiph/.pub-cache/hosted/pub.dev/flutter_soloud-2.0.0-pre.2/macos/Classes/../../src/flutter_soloud.cpp:54:
/Users/filiph/dev/flutter-codelabs/audio_soloud/soloud_game/macos/Flutter/ephemeral/.symlinks/plugins/flutter_soloud/src/soloud/src/audiosource/speech/klatt.cpp:762:33: warning: left operand of comma operator has no effect [-Wunused-value]
                                int stressdur = StressDur(p,stress);
                                                            ^~~~~~
#define StressDur(e,s) (s,((e->mDU + e->mUD)/2))
                        ^
In file included from /Users/filiph/.pub-cache/hosted/pub.dev/flutter_soloud-2.0.0-pre.2/macos/Classes/flutter_soloud.mm:3:
In file included from /Users/filiph/.pub-cache/hosted/pub.dev/flutter_soloud-2.0.0-pre.2/macos/Classes/../../src/flutter_soloud.cpp:60:
/Users/filiph/dev/flutter-codelabs/audio_soloud/soloud_game/macos/Flutter/ephemeral/.symlinks/plugins/flutter_soloud/src/soloud/src/audiosource/tedsid/sid.cpp:37:23: warning: implicit conversion loses integer precision: 'long' to 'unsigned int' [-Wshorten-64-to-32]
        unsigned int bit22 = bit(shiftReg,22);
                     ~~~~~   ^~~~~~~~~~~~~~~~
/Users/filiph/dev/flutter-codelabs/audio_soloud/soloud_game/macos/Flutter/ephemeral/.symlinks/plugins/flutter_soloud/src/soloud/src/audiosource/tedsid/sid.cpp:38:23: warning: implicit conversion loses integer precision: 'long' to 'unsigned int' [-Wshorten-64-to-32]
        unsigned int bit17 = bit(shiftReg,17);
                     ~~~~~   ^~~~~~~~~~~~~~~~
/Users/filiph/dev/flutter-codelabs/audio_soloud/soloud_game/macos/Flutter/ephemeral/.symlinks/plugins/flutter_soloud/src/soloud/src/audiosource/tedsid/sid.cpp:58:27: warning: implicit conversion loses integer precision: 'long' to 'int' [-Wshorten-64-to-32]
                (bit(shiftReg, 4) << 5) |
                ~~~~~~~~~~~~~~~~~~~~~~~~^
In file included from /Users/filiph/.pub-cache/hosted/pub.dev/flutter_soloud-2.0.0-pre.2/macos/Classes/flutter_soloud.mm:3:
In file included from /Users/filiph/.pub-cache/hosted/pub.dev/flutter_soloud-2.0.0-pre.2/macos/Classes/../../src/flutter_soloud.cpp:68:
/Users/filiph/dev/flutter-codelabs/audio_soloud/soloud_game/macos/Flutter/ephemeral/.symlinks/plugins/flutter_soloud/src/soloud/src/audiosource/wav/stb_vorbis.c:1394:20: warning: implicit conversion loses integer precision: 'long' to 'int' [-Wshorten-64-to-32]
      fseek(z->f, x+n, SEEK_SET);
      ~~~~~       ~^~
/Users/filiph/dev/flutter-codelabs/audio_soloud/soloud_game/macos/Flutter/ephemeral/.symlinks/plugins/flutter_soloud/src/soloud/src/audiosource/wav/stb_vorbis.c:3099:20: warning: possible misuse of comma operator here [-Wcomma]
            lx = hx, ly = hy;
                   ^
            lx = hx, ly = hy;
            ^~~~~~~
            static_cast<void>( )
/Users/filiph/dev/flutter-codelabs/audio_soloud/soloud_game/macos/Flutter/ephemeral/.symlinks/plugins/flutter_soloud/src/soloud/src/audiosource/wav/stb_vorbis.c:3340:25: warning: possible misuse of comma operator here [-Wcomma]
               m2 = m[j], a2 = m[j] - a[j];
                        ^
               m2 = m[j], a2 = m[j] - a[j];
               ^~~~~~~~~
               static_cast<void>( )
/Users/filiph/dev/flutter-codelabs/audio_soloud/soloud_game/macos/Flutter/ephemeral/.symlinks/plugins/flutter_soloud/src/soloud/src/audiosource/wav/stb_vorbis.c:3342:25: warning: possible misuse of comma operator here [-Wcomma]
               a2 = m[j], m2 = m[j] + a[j];
                        ^
               a2 = m[j], m2 = m[j] + a[j];
               ^~~~~~~~~
               static_cast<void>( )
/Users/filiph/dev/flutter-codelabs/audio_soloud/soloud_game/macos/Flutter/ephemeral/.symlinks/plugins/flutter_soloud/src/soloud/src/audiosource/wav/stb_vorbis.c:3345:25: warning: possible misuse of comma operator here [-Wcomma]
               m2 = m[j], a2 = m[j] + a[j];
                        ^
               m2 = m[j], a2 = m[j] + a[j];
               ^~~~~~~~~
               static_cast<void>( )
/Users/filiph/dev/flutter-codelabs/audio_soloud/soloud_game/macos/Flutter/ephemeral/.symlinks/plugins/flutter_soloud/src/soloud/src/audiosource/wav/stb_vorbis.c:3347:25: warning: possible misuse of comma operator here [-Wcomma]
               a2 = m[j], m2 = m[j] - a[j];
                        ^
               a2 = m[j], m2 = m[j] - a[j];
               ^~~~~~~~~
               static_cast<void>( )
/Users/filiph/dev/flutter-codelabs/audio_soloud/soloud_game/macos/Flutter/ephemeral/.symlinks/plugins/flutter_soloud/src/soloud/src/audiosource/wav/stb_vorbis.c:5092:24: warning: ISO C++11 does not allow conversion from string literal to 'char *' [-Wwritable-strings]
   f = fopen(filename, "rb");
                       ^
In file included from /Users/filiph/.pub-cache/hosted/pub.dev/flutter_soloud-2.0.0-pre.2/macos/Classes/flutter_soloud.mm:3:
In file included from /Users/filiph/.pub-cache/hosted/pub.dev/flutter_soloud-2.0.0-pre.2/macos/Classes/../../src/flutter_soloud.cpp:89:
/Users/filiph/dev/flutter-codelabs/audio_soloud/soloud_game/macos/Flutter/ephemeral/.symlinks/plugins/flutter_soloud/src/soloud/src/filter/soloud_fftfilter.cpp:175:10: warning: unused variable 'mag' [-Wunused-variable]
                        float mag = aFFTBuffer[i * 2];
                              ^
/Users/filiph/dev/flutter-codelabs/audio_soloud/soloud_game/macos/Flutter/ephemeral/.symlinks/plugins/flutter_soloud/src/soloud/src/filter/soloud_fftfilter.cpp:210:10: warning: unused variable 'mag' [-Wunused-variable]
                        float mag = aFFTBuffer[i * 2];
                              ^
In file included from /Users/filiph/.pub-cache/hosted/pub.dev/flutter_soloud-2.0.0-pre.2/macos/Classes/flutter_soloud.mm:3:
In file included from /Users/filiph/.pub-cache/hosted/pub.dev/flutter_soloud-2.0.0-pre.2/macos/Classes/../../src/flutter_soloud.cpp:103:
In file included from /Users/filiph/dev/flutter-codelabs/audio_soloud/soloud_game/macos/Flutter/ephemeral/.symlinks/plugins/flutter_soloud/src/bindings.cpp:1:
/Users/filiph/dev/flutter-codelabs/audio_soloud/soloud_game/macos/Flutter/ephemeral/.symlinks/plugins/flutter_soloud/src/player.h:51:16: warning: empty paragraph passed to '@return' command [-Wdocumentation]
    /// @return
        ~~~~~~~^
/Users/filiph/dev/flutter-codelabs/audio_soloud/soloud_game/macos/Flutter/ephemeral/.symlinks/plugins/flutter_soloud/src/player.h:51:10: warning: '@return' command used in a comment that is attached to a function returning void [-Wdocumentation]
    /// @return
        ~^~~~~~
/Users/filiph/dev/flutter-codelabs/audio_soloud/soloud_game/macos/Flutter/ephemeral/.symlinks/plugins/flutter_soloud/src/player.h:57:15: warning: empty paragraph passed to '@brief' command [-Wdocumentation]
    /// @brief
        ~~~~~~^
/Users/filiph/dev/flutter-codelabs/audio_soloud/soloud_game/macos/Flutter/ephemeral/.symlinks/plugins/flutter_soloud/src/player.h:58:25: warning: empty paragraph passed to '@param' command [-Wdocumentation]
    /// @param aErrorCode
        ~~~~~~~~~~~~~~~~^
/Users/filiph/dev/flutter-codelabs/audio_soloud/soloud_game/macos/Flutter/ephemeral/.symlinks/plugins/flutter_soloud/src/player.h:79:23: warning: empty paragraph passed to '@param' command [-Wdocumentation]
    /// @param waveform 
        ~~~~~~~~~~~~~~^
/Users/filiph/dev/flutter-codelabs/audio_soloud/soloud_game/macos/Flutter/ephemeral/.symlinks/plugins/flutter_soloud/src/player.h:80:24: warning: empty paragraph passed to '@param' command [-Wdocumentation]
    /// @param superWave 
        ~~~~~~~~~~~~~~~^
/Users/filiph/dev/flutter-codelabs/audio_soloud/soloud_game/macos/Flutter/ephemeral/.symlinks/plugins/flutter_soloud/src/player.h:81:20: warning: empty paragraph passed to '@param' command [-Wdocumentation]
    /// @param scale 
        ~~~~~~~~~~~^
/Users/filiph/dev/flutter-codelabs/audio_soloud/soloud_game/macos/Flutter/ephemeral/.symlinks/plugins/flutter_soloud/src/player.h:82:21: warning: empty paragraph passed to '@param' command [-Wdocumentation]
    /// @param detune 
        ~~~~~~~~~~~~^
/Users/filiph/dev/flutter-codelabs/audio_soloud/soloud_game/macos/Flutter/ephemeral/.symlinks/plugins/flutter_soloud/src/player.h:83:19: warning: empty paragraph passed to '@param' command [-Wdocumentation]
    /// @param hash 
        ~~~~~~~~~~^
/Users/filiph/dev/flutter-codelabs/audio_soloud/soloud_game/macos/Flutter/ephemeral/.symlinks/plugins/flutter_soloud/src/player.h:128:24: warning: empty paragraph passed to '@param' command [-Wdocumentation]
    /// @param soundHash
        ~~~~~~~~~~~~~~~^
/Users/filiph/dev/flutter-codelabs/audio_soloud/soloud_game/macos/Flutter/ephemeral/.symlinks/plugins/flutter_soloud/src/player.h:147:21: warning: empty paragraph passed to '@param' command [-Wdocumentation]
    /// @param handle
        ~~~~~~~~~~~~^
/Users/filiph/dev/flutter-codelabs/audio_soloud/soloud_game/macos/Flutter/ephemeral/.symlinks/plugins/flutter_soloud/src/player.h:151:24: warning: empty paragraph passed to '@param' command [-Wdocumentation]
    /// @param soundHash
        ~~~~~~~~~~~~~~~^
/Users/filiph/dev/flutter-codelabs/audio_soloud/soloud_game/macos/Flutter/ephemeral/.symlinks/plugins/flutter_soloud/src/player.h:155:24: warning: empty paragraph passed to '@param' command [-Wdocumentation]
    /// @param soundHash
        ~~~~~~~~~~~~~~~^
/Users/filiph/dev/flutter-codelabs/audio_soloud/soloud_game/macos/Flutter/ephemeral/.symlinks/plugins/flutter_soloud/src/player.h:155:16: warning: parameter 'soundHash' not found in the function declaration [-Wdocumentation]
    /// @param soundHash
               ^~~~~~~~~
/Users/filiph/dev/flutter-codelabs/audio_soloud/soloud_game/macos/Flutter/ephemeral/.symlinks/plugins/flutter_soloud/src/player.h:163:21: warning: empty paragraph passed to '@param' command [-Wdocumentation]
    /// @param handle
        ~~~~~~~~~~~~^
/Users/filiph/dev/flutter-codelabs/audio_soloud/soloud_game/macos/Flutter/ephemeral/.symlinks/plugins/flutter_soloud/src/player.h:164:21: warning: empty paragraph passed to '@param' command [-Wdocumentation]
    /// @param enable
        ~~~~~~~~~~~~^
/Users/filiph/dev/flutter-codelabs/audio_soloud/soloud_game/macos/Flutter/ephemeral/.symlinks/plugins/flutter_soloud/src/player.h:172:21: warning: empty paragraph passed to '@param' command [-Wdocumentation]
    /// @param handle 
        ~~~~~~~~~~~~^
/Users/filiph/dev/flutter-codelabs/audio_soloud/soloud_game/macos/Flutter/ephemeral/.symlinks/plugins/flutter_soloud/src/player.h:177:27: warning: empty paragraph passed to '@param' command [-Wdocumentation]
    /// @param textToSpeech
        ~~~~~~~~~~~~~~~~~~^
/Users/filiph/dev/flutter-codelabs/audio_soloud/soloud_game/macos/Flutter/ephemeral/.symlinks/plugins/flutter_soloud/src/player.h:184:22: warning: empty paragraph passed to '@param' command [-Wdocumentation]
    /// @param enabled
        ~~~~~~~~~~~~~^
/Users/filiph/dev/flutter-codelabs/audio_soloud/soloud_game/macos/Flutter/ephemeral/.symlinks/plugins/flutter_soloud/src/player.h:185:16: warning: empty paragraph passed to '@return' command [-Wdocumentation]
    /// @return
        ~~~~~~~^
/Users/filiph/dev/flutter-codelabs/audio_soloud/soloud_game/macos/Flutter/ephemeral/.symlinks/plugins/flutter_soloud/src/player.h:185:10: warning: '@return' command used in a comment that is attached to a function returning void [-Wdocumentation]
    /// @return
        ~^~~~~~
/Users/filiph/dev/flutter-codelabs/audio_soloud/soloud_game/macos/Flutter/ephemeral/.symlinks/plugins/flutter_soloud/src/player.h:199:24: warning: empty paragraph passed to '@param' command [-Wdocumentation]
    /// @param soundHash
        ~~~~~~~~~~~~~~~^
/Users/filiph/dev/flutter-codelabs/audio_soloud/soloud_game/macos/Flutter/ephemeral/.symlinks/plugins/flutter_soloud/src/player.h:240:21: warning: empty paragraph passed to '@param' command [-Wdocumentation]
    /// @param handle
        ~~~~~~~~~~~~^
In file included from /Users/filiph/.pub-cache/hosted/pub.dev/flutter_soloud-2.0.0-pre.2/macos/Classes/flutter_soloud.mm:3:
In file included from /Users/filiph/.pub-cache/hosted/pub.dev/flutter_soloud-2.0.0-pre.2/macos/Classes/../../src/flutter_soloud.cpp:103:
/Users/filiph/dev/flutter-codelabs/audio_soloud/soloud_game/macos/Flutter/ephemeral/.symlinks/plugins/flutter_soloud/src/bindings.cpp:702:31: warning: implicit conversion loses integer precision: 'size_type' (aka 'unsigned long') to 'int' [-Wshorten-64-to-32]
        *paramsCount = pNames.size();
                     ~ ~~~~~~~^~~~~~
/Users/filiph/dev/flutter-codelabs/audio_soloud/soloud_game/macos/Flutter/ephemeral/.symlinks/plugins/flutter_soloud/src/bindings.cpp:721:57: warning: result of comparison of constant -1 with expression of type 'bool' is always false [-Wtautological-constant-out-of-range-compare]
        if (player.mFilters.addGlobalFilter(filterType) == -1)
            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^  ~~
/Users/filiph/dev/flutter-codelabs/audio_soloud/soloud_game/macos/Flutter/ephemeral/.symlinks/plugins/flutter_soloud/src/bindings.cpp:735:60: warning: result of comparison of constant -1 with expression of type 'bool' is always false [-Wtautological-constant-out-of-range-compare]
        if (player.mFilters.removeGlobalFilter(filterType) == -1)
            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^  ~~
In file included from /Users/filiph/.pub-cache/hosted/pub.dev/flutter_soloud-2.0.0-pre.2/macos/Classes/flutter_soloud.mm:3:
In file included from /Users/filiph/.pub-cache/hosted/pub.dev/flutter_soloud-2.0.0-pre.2/macos/Classes/../../src/flutter_soloud.cpp:104:
/Users/filiph/dev/flutter-codelabs/audio_soloud/soloud_game/macos/Flutter/ephemeral/.symlinks/plugins/flutter_soloud/src/player.cpp:63:13: warning: enumeration values 'nullPointer', 'soundHashNotFound', and 'visualizationNotEnabled' not handled in switch [-Wswitch]
    switch (aErrorCode)
            ^~~~~~~~~~
    switch (aErrorCode)
            ^
/Users/filiph/dev/flutter-codelabs/audio_soloud/soloud_game/macos/Flutter/ephemeral/.symlinks/plugins/flutter_soloud/src/player.cpp:150:57: warning: implicit conversion from 'long long' to 'result_type' (aka 'unsigned int') changes value from 9223372036854775807 to 4294967295 [-Wconstant-conversion]
    std::uniform_int_distribution<unsigned int> dist(0, INT64_MAX);
                                                ~~~~    ^~~~~~~~~
In file included from <built-in>:1:
In file included from /Users/filiph/dev/flutter-codelabs/audio_soloud/soloud_game/macos/Pods/Target Support Files/flutter_soloud/flutter_soloud-prefix.pch:2:
In file included from /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX14.0.sdk/System/Library/Frameworks/Cocoa.framework/Headers/Cocoa.h:12:
In file included from /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX14.0.sdk/System/Library/Frameworks/Foundation.framework/Headers/Foundation.h:6:
In file included from /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX14.0.sdk/System/Library/Frameworks/CoreFoundation.framework/Headers/CoreFoundation.h:18:
In file included from /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX14.0.sdk/usr/include/sys/types.h:81:
In file included from /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX14.0.sdk/usr/include/machine/endian.h:37:
In file included from /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX14.0.sdk/usr/include/arm/endian.h:77:
In file included from /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX14.0.sdk/usr/include/sys/_endian.h:131:
In file included from /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX14.0.sdk/usr/include/libkern/_OSByteOrder.h:80:
In file included from /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX14.0.sdk/usr/include/libkern/arm/OSByteOrder.h:8:
In file included from /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX14.0.sdk/usr/include/c++/v1/stdint.h:124:
In file included from /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/clang/15.0.0/include/stdint.h:52:
#define INT64_MAX        9223372036854775807LL
                         ^~~~~~~~~~~~~~~~~~~~~
In file included from /Users/filiph/.pub-cache/hosted/pub.dev/flutter_soloud-2.0.0-pre.2/macos/Classes/flutter_soloud.mm:3:
In file included from /Users/filiph/.pub-cache/hosted/pub.dev/flutter_soloud-2.0.0-pre.2/macos/Classes/../../src/flutter_soloud.cpp:106:
In file included from /Users/filiph/dev/flutter-codelabs/audio_soloud/soloud_game/macos/Flutter/ephemeral/.symlinks/plugins/flutter_soloud/src/capture.cpp:1:
/Users/filiph/dev/flutter-codelabs/audio_soloud/soloud_game/macos/Flutter/ephemeral/.symlinks/plugins/flutter_soloud/src/capture.h:31:23: warning: empty paragraph passed to '@param' command [-Wdocumentation]
    /// @param deviceID 
        ~~~~~~~~~~~~~~^
/Users/filiph/dev/flutter-codelabs/audio_soloud/soloud_game/macos/Flutter/ephemeral/.symlinks/plugins/flutter_soloud/src/capture.h:32:16: warning: empty paragraph passed to '@return' command [-Wdocumentation]
    /// @return 
        ~~~~~~~^
/Users/filiph/dev/flutter-codelabs/audio_soloud/soloud_game/macos/Flutter/ephemeral/.symlinks/plugins/flutter_soloud/src/capture.h:36:16: warning: empty paragraph passed to '@return' command [-Wdocumentation]
    /// @return 
        ~~~~~~~^
/Users/filiph/dev/flutter-codelabs/audio_soloud/soloud_game/macos/Flutter/ephemeral/.symlinks/plugins/flutter_soloud/src/capture.h:36:10: warning: '@return' command used in a comment that is attached to a function returning void [-Wdocumentation]
    /// @return 
        ~^~~~~~
In file included from /Users/filiph/.pub-cache/hosted/pub.dev/flutter_soloud-2.0.0-pre.2/macos/Classes/flutter_soloud.mm:3:
In file included from /Users/filiph/.pub-cache/hosted/pub.dev/flutter_soloud-2.0.0-pre.2/macos/Classes/../../src/flutter_soloud.cpp:109:
/Users/filiph/dev/flutter-codelabs/audio_soloud/soloud_game/macos/Flutter/ephemeral/.symlinks/plugins/flutter_soloud/src/filters/filters.cpp:21:24: warning: implicit conversion loses integer precision: 'decltype(__x.base() - __y.base())' (aka 'long') to 'int' [-Wshorten-64-to-32]
        int index = it - filters.begin();
            ~~~~~   ~~~^~~~~~~~~~~~~~~~~
/Users/filiph/dev/flutter-codelabs/audio_soloud/soloud_game/macos/Flutter/ephemeral/.symlinks/plugins/flutter_soloud/src/filters/filters.cpp:139:42: warning: implicit conversion loses integer precision: 'size_type' (aka 'unsigned long') to 'unsigned int' [-Wshorten-64-to-32]
        mSoloud->setGlobalFilter(filters.size(), mBiquadResonantFilter.get());
                 ~~~~~~~~~~~~~~~ ~~~~~~~~^~~~~~
/Users/filiph/dev/flutter-codelabs/audio_soloud/soloud_game/macos/Flutter/ephemeral/.symlinks/plugins/flutter_soloud/src/filters/filters.cpp:145:42: warning: implicit conversion loses integer precision: 'size_type' (aka 'unsigned long') to 'unsigned int' [-Wshorten-64-to-32]
        mSoloud->setGlobalFilter(filters.size(), mEqFilter.get());
                 ~~~~~~~~~~~~~~~ ~~~~~~~~^~~~~~
/Users/filiph/dev/flutter-codelabs/audio_soloud/soloud_game/macos/Flutter/ephemeral/.symlinks/plugins/flutter_soloud/src/filters/filters.cpp:151:42: warning: implicit conversion loses integer precision: 'size_type' (aka 'unsigned long') to 'unsigned int' [-Wshorten-64-to-32]
        mSoloud->setGlobalFilter(filters.size(), mEchoFilter.get());
                 ~~~~~~~~~~~~~~~ ~~~~~~~~^~~~~~
/Users/filiph/dev/flutter-codelabs/audio_soloud/soloud_game/macos/Flutter/ephemeral/.symlinks/plugins/flutter_soloud/src/filters/filters.cpp:157:42: warning: implicit conversion loses integer precision: 'size_type' (aka 'unsigned long') to 'unsigned int' [-Wshorten-64-to-32]
        mSoloud->setGlobalFilter(filters.size(), mLofiFilter.get());
                 ~~~~~~~~~~~~~~~ ~~~~~~~~^~~~~~
/Users/filiph/dev/flutter-codelabs/audio_soloud/soloud_game/macos/Flutter/ephemeral/.symlinks/plugins/flutter_soloud/src/filters/filters.cpp:163:42: warning: implicit conversion loses integer precision: 'size_type' (aka 'unsigned long') to 'unsigned int' [-Wshorten-64-to-32]
        mSoloud->setGlobalFilter(filters.size(), mFlangerFilter.get());
                 ~~~~~~~~~~~~~~~ ~~~~~~~~^~~~~~
/Users/filiph/dev/flutter-codelabs/audio_soloud/soloud_game/macos/Flutter/ephemeral/.symlinks/plugins/flutter_soloud/src/filters/filters.cpp:169:42: warning: implicit conversion loses integer precision: 'size_type' (aka 'unsigned long') to 'unsigned int' [-Wshorten-64-to-32]
        mSoloud->setGlobalFilter(filters.size(), mBassboostFilter.get());
                 ~~~~~~~~~~~~~~~ ~~~~~~~~^~~~~~
/Users/filiph/dev/flutter-codelabs/audio_soloud/soloud_game/macos/Flutter/ephemeral/.symlinks/plugins/flutter_soloud/src/filters/filters.cpp:175:42: warning: implicit conversion loses integer precision: 'size_type' (aka 'unsigned long') to 'unsigned int' [-Wshorten-64-to-32]
        mSoloud->setGlobalFilter(filters.size(), mWaveShaperFilter.get());
                 ~~~~~~~~~~~~~~~ ~~~~~~~~^~~~~~
/Users/filiph/dev/flutter-codelabs/audio_soloud/soloud_game/macos/Flutter/ephemeral/.symlinks/plugins/flutter_soloud/src/filters/filters.cpp:181:42: warning: implicit conversion loses integer precision: 'size_type' (aka 'unsigned long') to 'unsigned int' [-Wshorten-64-to-32]
        mSoloud->setGlobalFilter(filters.size(), mRobotizeFilter.get());
                 ~~~~~~~~~~~~~~~ ~~~~~~~~^~~~~~
/Users/filiph/dev/flutter-codelabs/audio_soloud/soloud_game/macos/Flutter/ephemeral/.symlinks/plugins/flutter_soloud/src/filters/filters.cpp:187:42: warning: implicit conversion loses integer precision: 'size_type' (aka 'unsigned long') to 'unsigned int' [-Wshorten-64-to-32]
        mSoloud->setGlobalFilter(filters.size(), mFreeverbFilter.get());
                 ~~~~~~~~~~~~~~~ ~~~~~~~~^~~~~~
73 warnings generated.
warning: Run script build phase 'Run Script' will be run during every build because it does not specify any outputs. To address this warning, either add output dependencies to the script phase, or configure it to run in every build by unchecking "Based on dependency analysis" in the script phase. (in target 'Flutter Assemble' from project 'Runner')

Requirements

alnitak commented 6 months ago

I have already fixed those on bindings.cpp which I can see compiling on Linux. Fixed also those on filters.cpp which I don't see like many others from Soloud lib. I will push a commit soon.

alnitak commented 6 months ago

Since there were some warnings related to the documentation, I am updating also the soloud.dart method docs. Just to notify you and prevent us from doing the same thing at the same time.