v2.0 - Githubissues

alnitak / flutter_soloud

Flutter low-level audio plugin using SoLoud C++ library and FFI

MIT License

209 stars 21 forks source link

v2.0 #73

Closed alnitak closed 5 months ago

alnitak commented 5 months ago

Description

removed deprecated
CHANGELOG updated for v2.0

edit

removed MessageEvents.disposeEngine and MessageEvents.stopLoop enums alongside _stopLoop() and _disposeEngine() methods because were used in the old async disposeEngine(). All that work is now done by deinit().

Type of Change

[ ] ✨ New feature (non-breaking change which adds functionality)
[ ] 🛠️ Bug fix (non-breaking change which fixes an issue)
[ ] ❌ Breaking change (fix or feature that would cause existing functionality to change)
[ ] 🧹 Code refactor
[ ] ✅ Build configuration change
[x] 📝 Documentation
[x] 🗑️ Chore

filiph commented 5 months ago

Do I need to delete the fix_data.yaml file and the test_fixes directory?

No no, let's keep these. I don't know if they'll still work but it's worth having them around for a while.

In the CHANGELOG I have written the major changes since v1.2.5. Is that enough? Please, take a look if I missed something.

Makes sense to me!

I left the pre versions for reference before deleting them (if you agree to delete them).

I think we can keep those. The people who're still on 1.x will be interested in seeing the path, I think.

Tests passed on Linux, Android and Windows.

I'll try macOS and iOS once it lands.