added getPan, setPan and setPanAbsolute

alnitak / flutter_soloud

Flutter low-level audio plugin using SoLoud C++ library and FFI

MIT License

156 stars 15 forks source link

added getPan, setPan and setPanAbsolute #91

Closed alnitak closed 3 weeks ago

alnitak commented 3 weeks ago

Description

added getPan(), setPan() and setPanAbsolute() to fix #90.

Type of Change

[x] ✨ New feature (non-breaking change which adds functionality)
[ ] 🛠️ Bug fix (non-breaking change which fixes an issue)
[ ] ❌ Breaking change (fix or feature that would cause existing functionality to change)
[ ] 🧹 Code refactor
[ ] ✅ Build configuration change
[ ] 📝 Documentation
[ ] 🗑️ Chore

filiph commented 3 weeks ago

can you check if it grabs the state changes on iOS? For example when you put the app in the background or when the app is back in the foreground or maybe when a call is incoming while flutter_soloud is playing something, you should see a Log.fine() message (Audio engine state changed: [event]). This is out of scope of the PR, but I have added it while adding the others for simplicity. Thank you!

I don't see the change here. Is this something that landed in another PR?

I should have my iOS testing setup ready in a few minutes. Can test.

alnitak commented 3 weeks ago

I don't see the change here. Is this something that landed in another PR?

Yes, please test PR #89. A lot of changes on cpp side there.