Final Project Feedback

[ConsenSys-Academy]

Hey @alo9507 – Congratulations, your Final Project passed! We'll be approving it on the course itself in a week or two, but here's your feedback in the meanwhile:

Frontend

• The Github integration is really extraordinary, Andrew. Sounds like you've been working on this for a while, but it's really impressive! Glad you were able to incorporate it for the Bootcamp and beyond.
• I submitted a test bounty on your frontend but am mainly watching your walkthrough for settling the bounty. Great flow.
• Submitted some MATIC to my test bounty but got an Out of Gas error
• If you're thinking about user flow, would you consider a faucet for $FAKE for people to try out? Or you could manually send, just an idea.
• Nice to have it on Mumbai for cost reasons, as you say in the presentation.

Contract Design and Security

• I like your argument for deploying a separate contract for each bounty versus having a series of nested mappings. It does seem a bit ""cleaner"" and mentally easier to understand a single bounty having a single address.
• Have you all considered doing a selfdestruct function to also remove the contract from state?
• The escrow is a nice touch as well and an interesting design choice.
• I wasn't able to see this in the presentation or on the frontend, but did you need to do the approve then transfer for the ERC-20?
• Good coverage of the basic attack vectors.

Testing

• Nice clean setup of variables and beforeEach for the tests
• Good to test for existing Bounties, the crossover with Github and public blockchains is very interesting and does bring up different tests than pure blockchain cases.
• like the Arrange - Act - Assert comments here, always a fan of commenting to plan and I might borrow this one!
• Didn't realize that about Hardhat deploying with predictable addresses, how do you determine the address, say for bountyAddress?

Overall

• I'd really like to dive more into the Github "Oracle" you built for this project, @alo9507 . I appreciate you deciding not to work with Chainlink because this is more like an authoritative single endpoint rather than something that needs distributed consensus on.
• Overall, this is such a great project, @alo9507. I know it's beyond the scope of the course, but I hope you were able to use the time or material to build more on it. Please keep us posted with your progress, you should definitely share this with the wider community if you can. Excellent job!

[FlacoJones]

Thanks for your feedback! All great stuff. Some of my responses below:

I wasn't able to see this in the presentation or on the frontend, but did you need to do the approve then transfer for the ERC-20? So INITIALLY, for the platform you used, yes, we just had a few approved contract addresses and people simply sent directly to the issue.

We realized this, while good UX, made it hard to impossible to facilitate refunds without listening to Transfer events for all possible ERC20/ERC721. So now we use approve/transfer in later versions.

Submitted some MATIC to my test bounty but got an Out of Gas error: Argh! Wouldn't that be on your end not having enough MATIC on Mumbai to send money to the address?

Have you all considered doing a selfdestruct function to also remove the contract from state?: Is this just kind of a public good to reduce the hardware costs of running a node? Like picking up after yourself?

Didn't realize that about Hardhat deploying with predictable addresses, how do you determine the address, say for bountyAddress? I think that it's order based and maybe contract name based. On my machine and my partners machines, its always the same addresses somehow. Same contract name, same order, only two constant variables.

If you're thinking about user flow, would you consider a faucet for $FAKE for people to try out? Or you could manually send, just an idea. HELL YEAH! I've never made a faucet - great new project.

Good to test for existing Bounties, the crossover with Github and public blockchains is very interesting and does bring up different tests than pure blockchain cases.: Indeed....integration testing with ALL systems involved is a must

Thanks again for a great course!

[FlacoJones]

Oh actually, if the Out of Gas error came from the withdraw functionality then that must have been because I forgot to add some test MATIC onto mumbai Oracles wallet!