"macchanger -z" exits with 0

alobbs / macchanger

GNU MAC Changer

http://www.gnu.org/software/macchanger

GNU General Public License v3.0

581 stars 112 forks source link

"macchanger -z" exits with 0 #42

Open erjoalgo opened 7 years ago

erjoalgo commented 7 years ago

Passing an invalid option prints usage but exits with EXIT_OK instead of EXIT_ERROR. Caller scripts interpreting the exit status might think intended macchange operation was successful.

ghost commented 7 years ago

Download the sources and find all the files that contain the line _exit(0) or exit(0), find the right one and change it to _exit(1) or exit(1). PROFIT!

erjoalgo commented 7 years ago

@garilla22 that is exactly what I did 2 months ago as a PR in #44