aloctavodia / BAP3

Figures and code examples from Bayesian Analysis with Python (third edition)
http://bap.com.ar/
142 stars 41 forks source link

Incorrect Statement? Pg 94, commenting on Code 3.1/ 3.2 #28

Closed kenjioman closed 2 months ago

kenjioman commented 3 months ago

At the bottom of page 94, under code block 3.1, there is a line:

We are leaving 𝜎 without hyperpriors; in other words, we are assuming that the variance between observed and theoretical values should be the same for all groups.

However, we have a fully unpooled model with dims appearing in the prior. Thus, I believe the statement should actually be that we are assuming each group has its own unique 𝜎. To get the same variance for each group, I think we'd have to get rid of the dims argument in the prior for 𝜎 (and the corresponding [idx] in the likelihood).