search

alohaas / language-nunjucks

Syntax highlighting for nunjucks templates in atom.
MIT License
42 stars 13 forks source link

add file type/extension njk as nunjucks file extension per community #11

Closed dkebler closed 8 years ago

dkebler commented 8 years ago

tried it out in my local package install, works fine.

joelbschwartz commented 8 years ago

FWIW: https://github.com/mozilla/nunjucks/issues/685#issuecomment-186298507

dkebler commented 8 years ago

See this pr https://github.com/mozilla/nunjucks/pull/687 per https://groups.google.com/forum/#!topic/nunjucks/mJbJ96OPUGQ

ughitsaaron commented 8 years ago

What's the status of this pull request?

ughitsaaron commented 8 years ago

Thanks for the tip @puranjayjain

joelbschwartz commented 8 years ago

@ughitsaaron I'd strongly suggest sticking to this repository so the Atom community can keep just one download link for Nunjucks syntax highlighting. @alohaas does maintain this repository. While waiting for the file extension, you can just edit one line in the ~/.atom/packages/language-nunjucks/grammars/html (nunjucks templates).cson file (path for OS X). On line 4, add njk beneath the others.

alohaas commented 8 years ago

Hey @dkebler thanks for the PR request. This slipped under my radar because I was not mentioned in the original comment on the PR and my notifications settings aren't set correctly. I appreciate your vigilance @joelbschwartz. You're right that the activity of @puranjayjain violates the MIT license. I would like to continue maintaining this repo. I will update the contribution guidelines to ensure that contributors include a mention of my username in the comment and also update my notification settings.

alohaas commented 8 years ago

@dkebler LGTM :+1: Thank you for the update.

puranjayjain commented 8 years ago

@ughitsaaron please ignore my tip and follow @joelbschwartz 's advice he is right and I was too hasty to declare the repo abandoned the repo is maintained.