search

alohaas / language-nunjucks

Syntax highlighting for nunjucks templates in atom.
MIT License
42 stars 13 forks source link

Added the following things #15

Closed puranjayjain closed 8 years ago

puranjayjain commented 8 years ago

@alohaas Please review this:

alohaas commented 8 years ago

I really like the message for your commit @puranjayjain! I'm at work now so I will need to review this later today.

puranjayjain commented 8 years ago

that's ok take your time

alohaas commented 8 years ago

@puranjayjain no, thank you! this is a lesson learned for me – I should take better care of my OS projects. The irony of this is that my work is centered around OS projects. I should be as good a steward for my own as I am for others.

puranjayjain commented 8 years ago

@alohaas totally agree with you but with work and all people do get busy and cannot maintain something forever priorities change. I realized that I created a lot of ruckus on this repo and the best way to get me to realization is I put myself in your shoes. ... too much philosophy from me :grin:

joelbschwartz commented 8 years ago

These snippets look great. Excited for this PR. :) 👍

alohaas commented 8 years ago

@puranjayjain I made some suggested changes to the contribution guidelines, but otherwise everything else looks good! Both you and @joelbschwartz should let me know what you think of the guideline edits I suggested.

Everything else checks out and looks really good though so as soon as we resolve the contribution guidelines, I will merge and publish.

puranjayjain commented 8 years ago

@alohaas great! you have a green light from me go ahead and merge it, I think @joelbschwartz would agree with me on this.

joelbschwartz commented 8 years ago

@alohaas @puranjayjain Looks good to me!

alohaas commented 8 years ago

@puranjayjain thanks so much! Also thanks to @joelbschwartz Version 4.0 - "mega snippet boost" is live :rocket: