search

alohaas / language-nunjucks

Syntax highlighting for nunjucks templates in atom.
MIT License
42 stars 13 forks source link

Let's highlight the double curly braces, like in JSP language #23

Open revelt opened 7 years ago

revelt commented 7 years ago

Hi all,

Currently, Nunjucks variables within double curly braces are not highlighted any way:

nunjucks_curly —HTML(Nunjucks Templates) language

How nice would it be if the double curly braces were highlighted, for example, like in JSP language, notice the orange bits:

jsp_curly —JavaServer Pages language

What do you think?

alohaas commented 7 years ago

@revelt you're looking to have the curly braces a different color than the variable name? I think that's a nice idea :)

revelt commented 7 years ago

This issue is probably blocked by #21, isn't it?

ftm commented 7 years ago

@revelt Yeah I think once #21 is sorted out then we should be able to do this

revelt commented 7 years ago

I'm thinking, practically, should we attract some attention by Atom core team regarding #21 ? At least to get some consultation, is it possible at all and if so, how can this be done? Even a technical evaluation of the task would help to start issue moving eventually.

I'm worried that issues like this require deep expertise and neither commoners (like me) nor maintainers (correct me if I'm wrong) are not capable to solve this by themselves. We passively wait for somebody with expertise to come in and solve this, but statistically it's not likely. More often common people (like me) come in, have a glance but don't touch it because of lack of expertise.

I know Atom core team did work on languages so it might be within their scope.

@frasertmay What do you think?

ftm commented 7 years ago

It seems the language-mustache package was written by the Atom core team and they seem to manage this quite well:

screenshot at 2017-10-27 15 50 51

I'm not sure if they have a solution for #21 but I'll have a look.