alohaeditor / Aloha-Editor

Aloha Editor is a JavaScript content editing library
http://www.alohaeditor.org
Other
2.46k stars 535 forks source link

Paste is erratic in 0.9.3 and 0.10.alpha #266

Closed scottmessinger closed 12 years ago

scottmessinger commented 13 years ago

Hi,

Thanks for your hard work on this plugin. I'm having a hard time with paste working in either 0.9.3, 0.9.3.stable or 0.10.alpha. In both cases, paste occasionally works and occasionally doesn't. As in, sometimes pressing paste insert text and sometimes it doesn't.

It appears the only that that has changed from 0.9.3 to 0.9.3.stable and 0.10.alpha is the "DOM EXCEPTION" error message doesn't appear in the log. The problem remains.

I tried upgrading Rangy to the new 1.2 version and using it in the 0.9.3 stable branch, but the problem remains. Any ideas for a workaround?

Thanks! Scott

draftkraft commented 13 years ago

In the current dev die did a lot of bugfixing for paste. This should work stable... can you provide an example where it happens? Or content with which it happens?

scottmessinger commented 13 years ago

Thanks for the quick response! Later today, I'll find some examples and gist them. Do you want examples for the stable branch or 0.10?

On this note, 5 of the inserthtml tests on the 0.10 branch fail for me on Chome. More than 11 fail on FF. The paste bug seems to be in the insertIntoDOM function, so it seems related.

On 9/10/11, Haymo Meran reply@reply.github.com wrote:

In the current dev die did a lot of bugfixing for paste. This should work stable... can you provide an example where it happens? Or content with which it happens?

Reply to this email directly or view it on GitHub: https://github.com/alohaeditor/Aloha-Editor/issues/266#issuecomment-2059209

Sent from my mobile device

draftkraft commented 13 years ago

Hey,

I would prefer feedback on 0.10 alpha. Thanks for the feedback about the insertHTML tests. I noticed that too. Unfortunately this needs some more attention than expected. Although if you look in detail, it will not affect the user in most of the cases, because FF, chrome and others deal different with selections. So our job is to standardize selection responses. This will result in more stable results on command results. It could make a difference if the selection is between dom nodes or at the first position of a text node. I'm experimenting with selections in https://github.com/draftkraft/Aloha-Editor/blob/dev-commands/src/test/unit/selection.html

Cheers haymo

scottmessinger commented 12 years ago

Hi Haymo,

Sorry--I haven't posted any examples of the copy/paste selection with Aloha. I think I'm going to be moving to tinyMCE. I love what you are doing with Aloha but my users (and myself) find the floating toolbar rather annoying and I don't think its going to be fast or easy to eliminate all the copy/paste bugs. So, with not just one signifcant problem, but two, I don't think Aloha will work out. Also 0.10 is still a ways off. Had my time frame and the release of 0.10 lined up better, I think I could have stuck it out. Sadly, I think I'll have to move on.

I do wish you could make (and this might be possible with the new plugin architecture) a static toolbar, similiar to what they're doing with Mercury editor. http://jejacks0n.github.com/mercury/

Best of luck with the development of Aloha! -Scott

On Sun, Sep 11, 2011 at 12:50 PM, Haymo Meran < reply@reply.github.com>wrote:

Hey,

I would prefer feedback on 0.10 alpha. Thanks for the feedback about the insertHTML tests. I noticed that too. Unfortunately this needs some more attention than expected. Although if you look in detail, it will not affect the user in most of the cases, because FF, chrome and others deal different with selections. So our job is to standardize selection responses. This will result in more stable results on command results. It could make a difference if the selection is between dom nodes or at the for position of a text node. I'm experimenting with selections in https://github.com/draftkraft/Aloha-Editor/blob/dev-commands/src/test/unit/selection.html

Cheers haymo

Reply to this email directly or view it on GitHub: https://github.com/alohaeditor/Aloha-Editor/issues/266#issuecomment-2064593

draftkraft commented 12 years ago

Thanks for the feedback, Scott.

We actually plan to allow implementers to choose how they want to implement the UI.

Cheers hamyo