search

aloisdg / FeedParserPCL

FeedParserPCL is a PCL to parse Atom, Rss and Rdf feed.
MIT License
0 stars 0 forks source link

In case pubDate is absent in RSS 2.0 feed item, library throws exception #1

Open SashaPshenychniy opened 8 years ago

SashaPshenychniy commented 8 years ago

According to specification

< pubDate > is an optional sub-element of < item >

but source code doesn't handle it's absense correctly.

Data type for publication date should be Nullable< DateTime > instead of DateTime.

aloisdg commented 8 years ago

Hello,

Do you want to handle this and submit a PR? Or I can look myself later. Thank you for catching it.

By the way, you can use DateTime? as Nullable<DateTime>, it is a sugar :)

SashaPshenychniy commented 8 years ago

Currently I'm busy, but later I can fix it. Also I extended your library with support of author, images and publication source, but it's not well tested yet and also I need to get response from our lawyers about legal side since we do a commercial product.

PS: I didn't write DateTime? not to confuse you with question mark in a sentence =).

aloisdg commented 8 years ago

from our lawyers about legal side since we do a commercial product.

Currently I set MIT to be flexible. This license allows almost everything. With LGPL, you will have to push back your change to the library. If LGPL is fine, I will move to it. I used to use MPL and It could be see as lesser strict alternative to LGPL.

Ok for DateTime? ;)