Multiplying with strings causes `NaN`

aloisdg / Pizzule

Pizzule The Might Holy Pizza before the Apocalypse

GNU General Public License v3.0

1 stars 0 forks source link

Multiplying with strings causes `NaN` #9

Open wizzwizz4 opened 7 years ago

wizzwizz4 commented 7 years ago

When you choose a quantity, suddenly the total price becomes NaN. I really, really don't want my bank balance to have NaN subtracted from it because I quite like having a defined quantity of money.

Please fix.

aloisdg commented 7 years ago

Thank you for the issue!

@wendyg can you help me on this one?

wendyg commented 7 years ago

Troll ?

Le 29 oct. 2016 7:58 PM, "Alois" notifications@github.com a écrit :

Thank you for the issue!

@wendyg https://github.com/wendyg can you help me on this one?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/aloisdg/Pizzule/issues/9#issuecomment-257106113, or mute the thread https://github.com/notifications/unsubscribe-auth/AHHT_EMeGf5NV6pNqIk7ZViSn0kMBLJXks5q44lEgaJpZM4KkK5X .

wizzwizz4 commented 7 years ago

@wendyg Line 127 of main.js, Number(...) returns NaN. If there's still an error once this is fixed (occurring when pizza order is cancelled), also edit the removeProduct function's somethingQuantity variable assignment.

Disclaimer: I haven't checked any variable names and they are probably wrong. All line numbers may not be correct at time of posting, because I haven't had time to check those either.